Added support for ICMP-echo session stats#4613
Open
manamand2020 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jun 3, 2026
| using Traits = SaiOffloadHandlerTraits<T>; | ||
| using api_t = typename Traits::api_t; | ||
|
|
||
| SaiOffloadStatsHandler(const std::string& flex_counter_group, |
Collaborator
There was a problem hiding this comment.
Why header file is this big. Please move to a .cpp file.
Contributor
Author
There was a problem hiding this comment.
The header file has all the sai offload related template code that can be inlcuded safely and reused by other offload feature like bfdorch.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added support for ICMP echo session stats. The orchagent changes support both selective counters and native counters based on platform capability.
Related PRs:
sonic-net/SONiC#2354
sonic-net/sonic-swss-common#1192
sonic-net/sonic-sairedis#1910
sonic-net/sonic-utilities#4559
Why I did it
These changes will enable 'show icmp stats' which display icmpecho session stats.
How I verified it
Verified on hardware.
Mock and VS tests added.
Details if related