Use chandra_aca 2020 transforms with T_aca = T_ccd + 41 C#414
Merged
Use chandra_aca 2020 transforms with T_aca = T_ccd + 41 C#414
Conversation
5 tasks
Member
Author
jeanconn
reviewed
Mar 24, 2026
Contributor
|
Looks like there is also a yagzag_to_pixels call in jupiter.py and test_jupiter.py |
Member
Author
Fixed. |
jeanconn
approved these changes
Mar 24, 2026
2 tasks
This was referenced Apr 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates proseco to properly use the predicted ACA housing temperature in all pixel <=> y,z angle conversions. Previously the default ACA housing temperature of 20.0 C was used. Overall the difference is not substantial but this is a good opportunity to get it right.
This requires the changes in sot/chandra_aca#202 to use the full 19-coefficient 2020 plate scale calibration coefficients and use the T_aca (housing temperature) consistently.
Some regression test values required minor changes. One regression test was set to use the previous (20C) behavior to preserve the test exactly.
Requires
Interface impacts
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.