Skip to content

Use chandra_aca 2020 transforms with T_aca = T_ccd + 41 C#414

Merged
taldcroft merged 8 commits intomasterfrom
use-2020-aca-transform-coeffs
Mar 26, 2026
Merged

Use chandra_aca 2020 transforms with T_aca = T_ccd + 41 C#414
taldcroft merged 8 commits intomasterfrom
use-2020-aca-transform-coeffs

Conversation

@taldcroft
Copy link
Copy Markdown
Member

@taldcroft taldcroft commented Mar 17, 2026

Description

This updates proseco to properly use the predicted ACA housing temperature in all pixel <=> y,z angle conversions. Previously the default ACA housing temperature of 20.0 C was used. Overall the difference is not substantial but this is a good opportunity to get it right.

This requires the changes in sot/chandra_aca#202 to use the full 19-coefficient 2020 plate scale calibration coefficients and use the T_aca (housing temperature) consistently.

Some regression test values required minor changes. One regression test was set to use the previous (20C) behavior to preserve the test exactly.

Requires

Interface impacts

Testing

Unit tests

  • Mac (ska3 flight 2026.1 with chandra_aca @ 06d34eb)
(ska3-dev) ➜  proseco git:(use-2020-aca-transform-coeffs) git rev-parse --short HEAD       
df03b08
(ska3-dev) ➜  proseco git:(use-2020-aca-transform-coeffs) pytest 
========================================= test session starts =========================================
platform darwin -- Python 3.13.11, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: anyio-4.12.1, timeout-2.4.0
collected 250 items                                                                                   

proseco/tests/test_acq.py .....................................                                 [ 14%]
proseco/tests/test_catalog.py ..........................................                        [ 31%]
proseco/tests/test_core.py ............................                                         [ 42%]
proseco/tests/test_diff.py ......                                                               [ 45%]
proseco/tests/test_fid.py ...............                                                       [ 51%]
proseco/tests/test_guide.py ............................................................        [ 75%]
proseco/tests/test_guide_fid_optimization.py ............                                       [ 80%]
proseco/tests/test_jupiter.py ............................................                      [ 97%]
proseco/tests/test_mon_full_cat.py ......                                                       [100%]

=================================== 250 passed in 71.98s (0:01:11) ====================================

Independent check of unit tests by Jean

  • OSX
(ska3-latest) flame:proseco jean$ echo $PYTHONPATH
/Users/jean/git/chandra_aca
(ska3-latest) flame:proseco jean$ pytest
================================================================ test session starts ================================================================
platform darwin -- Python 3.13.11, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: anyio-4.12.1, timeout-2.4.0
collected 250 items                                                                                                                                 

proseco/tests/test_acq.py .....................................                                                                               [ 14%]
proseco/tests/test_catalog.py ..........................................                                                                      [ 31%]
proseco/tests/test_core.py ............................                                                                                       [ 42%]
proseco/tests/test_diff.py ......                                                                                                             [ 45%]
proseco/tests/test_fid.py ...............                                                                                                     [ 51%]
proseco/tests/test_guide.py ............................................................                                                      [ 75%]
proseco/tests/test_guide_fid_optimization.py ............                                                                                     [ 80%]
proseco/tests/test_jupiter.py ............................................                                                                    [ 97%]
proseco/tests/test_mon_full_cat.py ......                                                                                                     [100%]

========================================================== 250 passed in 74.22s (0:01:14) ===========================================================
(ska3-latest) flame:proseco jean$ git rev-parse HEAD
df03b083cf22b4ffcdf50a578d1a566397377e77
(ska3-latest) flame:proseco jean$ python -c "import chandra_aca; print(chandra_aca.__version__)"
4.54.1.dev23+g06d34ebbe

Functional tests

No functional testing.

@taldcroft taldcroft changed the title Update tests for chandra_aca 2020 transform coeffs Use chandra_aca 2020 transforms with T_aca = T_ccd + 41 C Mar 24, 2026
@taldcroft taldcroft requested a review from jeanconn March 24, 2026 16:18
@taldcroft
Copy link
Copy Markdown
Member Author

@jeanconn - this should be ready for final review now. In 239ad34, I set up some characteristics to use the "old" 20C behavior to show that tests were passing. Then the next commit goes to the final characteristics values which require some test updates.

Comment thread proseco/core.py Outdated
@jeanconn
Copy link
Copy Markdown
Contributor

Looks like there is also a yagzag_to_pixels call in jupiter.py and test_jupiter.py

@taldcroft
Copy link
Copy Markdown
Member Author

Looks like there is also a yagzag_to_pixels call in jupiter.py and test_jupiter.py

Fixed.

@taldcroft taldcroft merged commit 4926c55 into master Mar 26, 2026
2 checks passed
@taldcroft taldcroft deleted the use-2020-aca-transform-coeffs branch March 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants