Skip to content

Enabling ci build for py-torch 2.9, 2.10 on rocm - #3287

Closed
renjithravindrankannath wants to merge 34 commits into
spack:developfrom
renjithravindrankannath:py-torch-2.10-rocm
Closed

Enabling ci build for py-torch 2.9, 2.10 on rocm#3287
renjithravindrankannath wants to merge 34 commits into
spack:developfrom
renjithravindrankannath:py-torch-2.10-rocm

Conversation

@renjithravindrankannath

Copy link
Copy Markdown
Contributor

No description provided.

@spackbot-triage spackbot-triage Bot added python dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository conflicts Modifications with a `conflicts()` directive labels Feb 6, 2026
@spackbot-triage
spackbot-triage Bot requested a review from bgoglin February 6, 2026 19:48
@renjithravindrankannath
renjithravindrankannath marked this pull request as draft February 6, 2026 19:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables building the PyTorch ecosystem in the ROCm CI stack by turning on additional PyTorch-adjacent Python packages and updating the Spack py-torch recipe to better align with ROCm 7 requirements for PyTorch 2.9+.

Changes:

  • Enable multiple PyTorch ecosystem packages (including py-torch, py-torchdata, py-torchmetrics, etc.) in the ml-linux-x86_64-rocm stack.
  • Update py-torch Spack package ROCm constraints/deps for PyTorch 2.9+ (e.g., ROCm 7 component minimums, hip/hipblaslt constraints, additional deps).
  • Bump hwloc’s ROCm SMI dependency minimum to rocm-smi-lib@7.0:.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stacks/ml-linux-x86_64-rocm/spack.yaml Enables PyTorch ecosystem Python packages in the ROCm CI stack.
repos/spack_repo/builtin/packages/py_torch/package.py Updates ROCm dependency constraints and build/patch logic for newer PyTorch on ROCm.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.7.patch Patch metadata updates and ROCm include handling adjustment for PyTorch 2.7 sources.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch Patch metadata updates and ROCm include handling adjustment for PyTorch 2.5 sources.
repos/spack_repo/builtin/packages/hwloc/package.py Requires ROCm SMI library 7.0+ when +rocm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread repos/spack_repo/builtin/packages/py_torch/package.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalazo this will make your #3175 a bit simpler

Comment thread stacks/ml-linux-x86_64-rocm/spack.yaml
- py-torchdata
- py-torchgeo
- py-torchmetrics
# - py-torchvision

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there problems building torchaudio/torchvision with rocm support? torchgeo depends on torchvision, so if the CI is passing, I don't expect these to be an issue.

Comment thread repos/spack_repo/builtin/packages/py_torch/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_torch/package.py Outdated
@adamjstewart adamjstewart self-assigned this Feb 8, 2026
@renjithravindrankannath
renjithravindrankannath marked this pull request as ready for review February 9, 2026 09:21
@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot rerun pipeline

@spackbot-app

spackbot-app Bot commented Feb 9, 2026

Copy link
Copy Markdown

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'message': '404 Commit Not Found'}

@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot rerun pipeline

@spackbot-app

spackbot-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@spackbot-triage
spackbot-triage Bot requested a review from afzpatel February 11, 2026 06:54
@spackbot-triage spackbot-triage Bot added the ci Related to CI/CD workflows and pipelines label Feb 12, 2026
@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives new-variant Modifications to packages' `variant()` directives remove-package and removed python conflicts Modifications with a `conflicts()` directive labels Mar 2, 2026
@renjithravindrankannath

renjithravindrankannath commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Unwanted changes are getting merged. Hence closing this PR and new PR is #3630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to CI/CD workflows and pipelines dependencies Modifications with a `depends_on()` directive new-variant Modifications to packages' `variant()` directives new-version Modifications to packages' `depends_on()` directives remove-package update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants