Enabling ci build for py-torch 2.9, 2.10 on rocm

.ci/env

@@ -1,2 +1,2 @@
-SPACK_CHECKOUT_VERSION=06f3ac473591a77e6a623838fc2b164b7c06023b
+SPACK_CHECKOUT_VERSION=a429ffcb690fc2098657e6ed14e12ad6af48c928
 SPACK_CHECKOUT_REPO=spack/spack

.ci/gitlab/.gitlab-ci.yml

@@ -489,6 +489,28 @@ radiuss-build:
     SPACK_CI_TARGET: "x86_64_v4"
   tags: ["spack", "public", "aws", "medium", "x86_64_v4"]
 
+.radiuss-cuda:
+  variables:
+    SPACK_CI_STACK_NAME: radiuss-cuda
+
+radiuss-cuda-generate:
+  extends: [ ".radiuss-cuda", ".generate-x86_64", ".tags-x86_64_v4" ]
+  image:
+    name: ghcr.io/spack/ubuntu-24.04:v2024-09-05-v2
+    entrypoint: ['']
+
+radiuss-cuda-build:
+  extends: [ ".radiuss-cuda", ".build" ]
+  trigger:
+    << : *trigger_build
+    include:
+      - artifact: jobs_scratch_dir/radiuss-cuda/cloud-ci-pipeline.yml
+        job: radiuss-cuda-generate
+  needs:
+    - artifacts: True
+      job: radiuss-cuda-generate
+
+
 # Parallel Pipeline for aarch64 (reuses override image, but generates and builds on aarch64)
 
 .radiuss-aarch64:
@@ -568,7 +590,7 @@ tools-sdk-build:
 
 tutorial-generate:
   extends: [ ".tutorial", ".generate-x86_64"]
-  image: ghcr.io/spack/tutorial-ubuntu-22.04:main
+  image: ghcr.io/spack/tutorial-ubuntu-22.04:v2023-10-30
 
 tutorial-build:
   extends: [ ".tutorial", ".build" ]
@@ -581,49 +603,115 @@ tutorial-build:
     - artifacts: True
       job: tutorial-generate
 
-#################################
-# Machine Learning - Linux x86_64
-#################################
-.ml-linux-x86_64:
+#######################################
+# Machine Learning - Linux x86_64 (CPU)
+#######################################
+.ml-linux-x86_64-cpu:
+  variables:
+    SPACK_CI_STACK_NAME: ml-linux-x86_64-cpu
+
+ml-linux-x86_64-cpu-generate:
+  extends: [ ".generate-x86_64", .ml-linux-x86_64-cpu, ".tags-x86_64_v4" ]
+  image: ghcr.io/spack/ubuntu-24.04:v2025-09-15
+
+ml-linux-x86_64-cpu-build:
+  extends: [ ".build", ".ml-linux-x86_64-cpu" ]
+  trigger:
+    << : *trigger_build
+    include:
+      - artifact: jobs_scratch_dir/ml-linux-x86_64-cpu/cloud-ci-pipeline.yml
+        job: ml-linux-x86_64-cpu-generate
+  needs:
+    - artifacts: True
+      job: ml-linux-x86_64-cpu-generate
+
+########################################
+# Machine Learning - Linux x86_64 (CUDA)
+########################################
+.ml-linux-x86_64-cuda:
   variables:
-    SPACK_CI_STACK_NAME: ml-linux-x86_64
+    SPACK_CI_STACK_NAME: ml-linux-x86_64-cuda
 
-ml-linux-x86_64-generate:
-  extends: [ ".generate-x86_64", .ml-linux-x86_64, ".tags-x86_64_v4" ]
+ml-linux-x86_64-cuda-generate:
+  extends: [ ".generate-x86_64", .ml-linux-x86_64-cuda, ".tags-x86_64_v4" ]
   image: ghcr.io/spack/ubuntu-24.04:v2025-09-15
 
-ml-linux-x86_64-build:
-  extends: [ ".build", ".ml-linux-x86_64" ]
+ml-linux-x86_64-cuda-build:
+  extends: [ ".build", ".ml-linux-x86_64-cuda"  ]
   trigger:
     << : *trigger_build
     include:
-      - artifact: jobs_scratch_dir/ml-linux-x86_64/cloud-ci-pipeline.yml
-        job: ml-linux-x86_64-generate
+      - artifact: jobs_scratch_dir/ml-linux-x86_64-cuda/cloud-ci-pipeline.yml
+        job: ml-linux-x86_64-cuda-generate
   needs:
     - artifacts: True
-      job: ml-linux-x86_64-generate
+      job: ml-linux-x86_64-cuda-generate
 
-##################################
-# Machine Learning - Linux aarch64
-##################################
-.ml-linux-aarch64:
+########################################
+# Machine Learning - Linux x86_64 (ROCm)
+########################################
+.ml-linux-x86_64-rocm:
+  variables:
+    SPACK_CI_STACK_NAME: ml-linux-x86_64-rocm
+
+ml-linux-x86_64-rocm-generate:
+  extends: [ ".generate-x86_64", .ml-linux-x86_64-rocm, ".tags-x86_64_v4" ]
+  image: ghcr.io/spack/ubuntu-24.04:v2025-09-15
+
+ml-linux-x86_64-rocm-build:
+  extends: [ ".build", ".ml-linux-x86_64-rocm" ]
+  trigger:
+    << : *trigger_build
+    include:
+      - artifact: jobs_scratch_dir/ml-linux-x86_64-rocm/cloud-ci-pipeline.yml
+        job: ml-linux-x86_64-rocm-generate
+  needs:
+    - artifacts: True
+      job: ml-linux-x86_64-rocm-generate
+
+########################################
+# Machine Learning - Linux aarch64 (CPU)
+########################################
+.ml-linux-aarch64-cpu:
+  variables:
+    SPACK_CI_STACK_NAME: ml-linux-aarch64-cpu
+
+ml-linux-aarch64-cpu-generate:
+  extends: [ ".generate-aarch64", .ml-linux-aarch64-cpu ]
+  image: ghcr.io/spack/ubuntu-24.04:v2025-09-15
+
+ml-linux-aarch64-cpu-build:
+  extends: [ ".build", ".ml-linux-aarch64-cpu" ]
+  trigger:
+    << : *trigger_build
+    include:
+      - artifact: jobs_scratch_dir/ml-linux-aarch64-cpu/cloud-ci-pipeline.yml
+        job: ml-linux-aarch64-cpu-generate
+  needs:
+    - artifacts: True
+      job: ml-linux-aarch64-cpu-generate
+
+#########################################
+# Machine Learning - Linux aarch64 (CUDA)
+#########################################
+.ml-linux-aarch64-cuda:
   variables:
-    SPACK_CI_STACK_NAME: ml-linux-aarch64
+    SPACK_CI_STACK_NAME: ml-linux-aarch64-cuda
 
-ml-linux-aarch64-generate:
-  extends: [ ".generate-aarch64", .ml-linux-aarch64 ]
+ml-linux-aarch64-cuda-generate:
+  extends: [ ".generate-aarch64", .ml-linux-aarch64-cuda ]
   image: ghcr.io/spack/ubuntu-24.04:v2025-09-15
 
-ml-linux-aarch64-build:
-  extends: [ ".build", ".ml-linux-aarch64" ]
+ml-linux-aarch64-cuda-build:
+  extends: [ ".build", ".ml-linux-aarch64-cuda" ]
   trigger:
     << : *trigger_build
     include:
-      - artifact: jobs_scratch_dir/ml-linux-aarch64/cloud-ci-pipeline.yml
-        job: ml-linux-aarch64-generate
+      - artifact: jobs_scratch_dir/ml-linux-aarch64-cuda/cloud-ci-pipeline.yml
+        job: ml-linux-aarch64-cuda-generate
   needs:
     - artifacts: True
-      job: ml-linux-aarch64-generate
+      job: ml-linux-aarch64-cuda-generate
 
 #########################################
 # Machine Learning - Darwin aarch64 (MPS)

.ci/gitlab/configs/linux/ci.yaml

@@ -13,6 +13,8 @@ ci:
       - wrf
       build-job:
         tags: [ "spack", "huge" ]
+        # 24h for long ROCm/ML rebuilds; GitLab project/runner max must allow this
+        timeout: 1440 minutes
         variables:
           CI_JOB_SIZE: huge
           SPACK_BUILD_JOBS: "12"

CODEOWNERS

@@ -24,7 +24,9 @@
 /stacks/tools-sdk/                            @kwryankrattiger
 /stacks/tutorial/                             @alecbcs @becker33 @tldahlgren @tgamblin
 /stacks/windows-vis/                          @johnwparent @kwryankrattiger @scheibelp
-/stacks/radiuss*/                             @adrienbernede @davidbeckingsale
+/stacks/radiuss/                              @adrienbernede @davidbeckingsale
+/stacks/radiuss-cuda/                         @adrienbernede @davidbeckingsale
+/stacks/radiuss-aarch64/                      @adrienbernede @davidbeckingsale
 
 ###
 # CI Components maintained by Kitware

repos/spack_repo/builtin/packages/acts/package.py

@@ -50,7 +50,6 @@ class Acts(CMakePackage, CudaPackage):
 
     # Supported Acts versions
     version("main", branch="main")
-    version("45.3.0", commit="d1323a298569942d98ff46ee413031ebd604290d")
     version("45.2.0", commit="c476557b74ccc8369fe1ef2c1f2e27cca4a356b6")
     version("45.1.1", commit="da50efc7b15cad8fdc5e194719c72d7d8b706823")
     version("45.1.0", commit="061a9d87b0fc07b554ec0b3849e875cf964f8323")
@@ -477,7 +476,6 @@ class Acts(CMakePackage, CudaPackage):
     depends_on("py-particle @0.24", when="@44:")
     depends_on("py-pybind11 @2.6.2:", when="+python @18:")
     depends_on("py-pybind11 @2.13.1:", when="+python @36:")
-    depends_on("py-pybind11 @3.0.1:", when="+python @45.3:")
     depends_on("py-pytest", when="+python +unit_tests")
     depends_on("py-setuptools", when="@44:44.1.0")
     depends_on("py-sympy @1.13", when="@44:")

repos/spack_repo/builtin/packages/cargo_c/package.py

@@ -19,8 +19,5 @@ class CargoC(CargoPackage):
     version("0.10.17", sha256="a92b752f35e3ef54c992b2ba382466eb58a11020d13e62a25a4101bc055d5146")
     version("0.10.16", sha256="c0ebb3175393da5b55c3cd83ba1ae9d42d32e2aece6ceff1424239ffb68eb3e3")
 
-    depends_on("c", type="build")
-
-    depends_on("openssl")
     depends_on("rust@1.89:", type="build", when="@0.10.17:")
     depends_on("rust@1.88:", type="build", when="@0.10.16:")

repos/spack_repo/builtin/packages/composable_kernel/package.py

@@ -3,7 +3,7 @@
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
 
 
-from spack_repo.builtin.build_systems.cmake import CMakePackage, generator
+from spack_repo.builtin.build_systems.cmake import CMakePackage
 from spack_repo.builtin.build_systems.rocm import ROCmPackage
 
 from spack.package import *
@@ -71,8 +71,6 @@ def url_for_version(self, version):
     depends_on("pkgconfig", type="build")
     depends_on("cmake@3.16:", type="build")
 
-    generator("ninja")
-
     for ver in [
         "7.2.0",
         "7.1.1",
@@ -139,3 +137,11 @@ def cmake_args(self):
         if self.spec.satisfies("@6.2:"):
             args.append(self.define("BUILD_DEV", "OFF"))
         return args
+
+    def build(self, spec, prefix):
+        with working_dir(self.build_directory):
+            # only instances is necessary to build and install
+            if self.spec.satisfies("@5.6.0:"):
+                make()
+            else:
+                make("instances")

repos/spack_repo/builtin/packages/eccodes/package.py

@@ -101,7 +101,7 @@ class Eccodes(CMakePackage):
 
     depends_on("c", type="build")  # generated
     depends_on("cxx", type="build")  # generated
-    depends_on("fortran", when="+fortran", type="build")
+    depends_on("fortran", type="build")  # generated
 
     depends_on("netcdf-c", when="+netcdf")
     # Cannot be built with openjpeg@2.0.x.