Skip to content

omega-h: add v11.2.0-scorec and a python variant - #5792

Merged
bernhardkaindl merged 7 commits into
spack:developfrom
Sichao25:omegah_python
Aug 10, 2026
Merged

omega-h: add v11.2.0-scorec and a python variant#5792
bernhardkaindl merged 7 commits into
spack:developfrom
Sichao25:omegah_python

Conversation

@Sichao25

Copy link
Copy Markdown
Contributor

This PR adds Omega_h version 11.2.0-scorec. It also supports python variant from now.

@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository conflicts Modifications with a `conflicts()` directive new-variant Modifications to packages' `variant()` directives extends labels Jul 29, 2026
@spackbot-triage
spackbot-triage Bot requested a review from cwsmith July 29, 2026 16:48
@Sichao25

This comment was marked as duplicate.

@spackbot-app

This comment was marked as duplicate.

@spackbot-app

This comment was marked as duplicate.

Comment thread repos/spack_repo/builtin/packages/omega_h/package.py Outdated
@spackbot-triage
spackbot-triage Bot requested a review from cwsmith August 3, 2026 17:55
@Sichao25

This comment was marked as outdated.

@spackbot-app

This comment was marked as duplicate.

@spackbot-app

This comment was marked as duplicate.

@bernhardkaindl bernhardkaindl changed the title omegah: version 11.2.0-scorec omega-h: add v11.2.0-scorec and a python variant Aug 6, 2026
@bernhardkaindl

bernhardkaindl commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@Sichao25 as agreed with @cwsmith in #4672, I merged the pre-existing earlier PR first because of the git conflict between them and I think it is easier to rebase this new PR on top of the merge: #4672 (review)

As the view of this PR on Github now shows, the conflict now needs to be resolved in this PR. Can you do that?

If possible, it would be great if you could do it with a git rebase on top of the latest develop branch (not using a git merge) because then your branch keep the real git history of develop as base, and your changes stay on top of the history, which can make the review much easier if one needs to look at your commits to the PR. Thanks, Bernhard

PS: Also, there seems to be a libomega_h.so: undefined reference to nc_set_log_level'triggered byspack install omega-h +exodus +mpi +sharednow. It looks like onlynetcdf-cprovides it butparallel-netcdfnot, which I saw used in the build log of+exodus +mpi`.

@bernhardkaindl bernhardkaindl changed the title omega-h: add v11.2.0-scorec and a python variant omega-h: add v11.2.0-scorec and a python variant [git conflicts: needs rebase] Aug 6, 2026
@jacobmerson

Copy link
Copy Markdown
Contributor

@Sichao25 please add the following line to this PR which with the updates in SCOREC/omega_h#228 will enable the PyOmega_h python package to directly be used in a spack environment without any manual modification of PYTHONPATH or LD_LIBRARY_PATH.

extends('python', when='+python')

See the use in PCMS for example: https://github.com/jacobmerson/pcms-spack/blob/e9a7bd00201c871da0a4ffe14e17c3b5e6d2c86d/spack_repo/pcms/packages/pcms/package.py#L58

@Sichao25

Sichao25 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@bernhardkaindl Thanks for the notification. I've rebased the branch. However, I wasn't able to reproduce the libomega_h link error with spack install +exodus +mpi +shared alone. Could you let me know where can I find more details on which full spec triggers this?

@bernhardkaindl bernhardkaindl changed the title omega-h: add v11.2.0-scorec and a python variant [git conflicts: needs rebase] omega-h: add v11.2.0-scorec and a python variant Aug 6, 2026
@bernhardkaindl

bernhardkaindl commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@Sichao25, thanks for checking. In a new docker container, I did a completely fresh install of spack develop, setup https://cache.spack.io as buildcache and this latest PR branch on ARM64 today (using the and it didn't reproduce there.

bernhardkaindl
bernhardkaindl previously approved these changes Aug 6, 2026
@bernhardkaindl
bernhardkaindl self-requested a review August 6, 2026 23:37
@bernhardkaindl
bernhardkaindl enabled auto-merge (squash) August 6, 2026 23:41
Comment thread repos/spack_repo/builtin/packages/omega_h/package.py Outdated
…pi +shared"

Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
@spack spack deleted a comment from spackbot-app Bot Aug 10, 2026
@spack spack deleted a comment from spackbot-app Bot Aug 10, 2026
@bernhardkaindl
bernhardkaindl merged commit 4ff8709 into spack:develop Aug 10, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts Modifications with a `conflicts()` directive dependencies Modifications with a `depends_on()` directive extends new-variant Modifications to packages' `variant()` directives new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants