Correct Sint Maarten / Saint Martin customer-facing labels (#124) - #125
Merged
Merged
Conversation
PR #120 grouped venues under the internal canonical `sxm` key but displayed "Sint Maarten / Saint Martin / SXM" — SXM is not a third jurisdiction on the island. The public label is now exactly "Sint Maarten / Saint Martin" via the canonical ISLAND_DISPLAY_NAMES mapping, which covers the filter option and group heading in one place. Also replaces whole-island "SXM" shorthand in metadata, FAQ JSON-LD, intro copy, and contact/homepage/trade descriptions. Internal keys, fixture data, meta keywords, the areaServed alias, and the Dutch-side "shipping coordination to SXM" wording are unchanged. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Reviewer's GuideCorrects the customer-facing Sint Maarten / Saint Martin terminology while preserving the internal File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #120 grouped venues under the internal canonical
sxmkey but set the public label toSint Maarten / Saint Martin / SXM— presentingSXMas a third equivalent name. Sint Maarten (Dutch side) and Saint Martin (French side) are the two jurisdictions on one island, so the customer-facing label is now exactlySint Maarten / Saint Martin.Closes #124
Changes
lib/venue-filters.ts: canonicalISLAND_DISPLAY_NAMESentry forsxm→Sint Maarten / Saint Martin(single mapping drives both the Island filter option and the group heading).app/(pages)/where-to-buy/page.tsx: meta/OG/Twitter descriptions, FAQ JSON-LD question + answers, intro copy, and the Regional Availability label all useSint Maarten / Saint Martininstead ofSXMshorthand.app/page.tsx+app/(pages)/contact/page.tsx+app/(pages)/trade/page.tsx: whole-islandSXMshorthand in descriptions/copy replaced withSint Maarten / Saint Martin.docs/admin/managing-locations.md: heading description updated to match.SXMnever appears in the filter options (toHaveCount(0)on options containing "SXM") or the display name.Retained intentionally: internal
sxmcanonical key,?island=sxmURLs,hasSxm, fixturelocationName: "SXM"(deliberately exercises normalization), meta keywords (where to buy beer on SXMis a real search query),areaServedJSON-LD"SXM"alias (consistent with theSint Eustatius/Statiadual listing), about page's Dutch-sideSint Maartenreference, andshipping coordination to SXMon/trade(ambiguous Dutch-side operational copy — flagged for owner review rather than guessed).Verification
npx tsc --noEmit— cleannpm run lint— clean (one pre-existing jsx-ast-utils notice, also on main)npm test— 350 passnpm run test:rules— 29 passnpm run build— passnpm run test:smoke— 117 passnpm run check:md-links— passnpm run check:react-versions— passnpm audit --omit=dev— 0 vulnerabilities/where-to-buy-fixtureat 1280px and 375px — filter option andSint Maarten / Saint Martinheading render correctly; venue cards keep raw locality text;/tradecopy verifiedRisk / deployment notes
Copy/terminology only — no schema, data, filtering, analytics, or distribution-claim changes. Note: PR #123 (open) rewrites the same
/tradelines; whichever merges second will need a trivial rebase, and #123's copy contains the sameSXMshorthand that should get this fix.Generated with Devin
Summary by Sourcery
Use “Sint Maarten / Saint Martin” consistently as the public label while retaining
sxmfor internal grouping and URLs.Bug Fixes:
Enhancements:
Documentation:
Tests: