Skip to content

det: JSON GENERATE NAME OF the source IS OMITTED (Part of #7524) - #7938

Open
squid-protocol wants to merge 3 commits into
mainfrom
churn/7524-20261106T1843Z
Open

squid-protocol wants to merge 3 commits into
mainfrom
churn/7524-20261106T1843Z

Conversation

@squid-protocol

@squid-protocol squid-protocol commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

JSON GENERATE NAME OF <source> IS OMITTED is translated from IBM's definition (Enterprise COBOL 6.3 LR, JSON GENERATE, NAME phrase: OMITTED "generate[s] an anonymous JSON object, whose top-level parent name is not generated"; identifier-4 must reference identifier-2). The text is the source group's {members} alone instead of {"SRC":{members}}. Oracle-unbacked (GnuCOBOL has no JSON statement): register X76 records it as ASSUMED, no L2+ claim. IBM shows no example text, so the reading is stated as an assumption there.

  • stmt.py: the NAME phrase takes IS OMITTED for GENERATE only (JSON PARSE still refuses it).
  • gen.py (json_tree): OMITTED on the source wraps the tree in anonymous(...); OMITTED on any other item is refused by name; the last NAME specification of the source wins (IBM).
  • JsonGenerate.java: anonymous(Node); tryGenerate writes the root's value alone for it. cobolrt_api.json / cobolrt_rules.json updated.
  • Tests: parse, translation, last-wins, member refusal, runtime text.

Checklist: partial [c:bb8e1760] -- CONVERTING, floats, elementary source stay refused, JSON-STATUS, NAME OMITTED on a member stay refused (JSON-CODE after an exception landed in #7930)

Class / Sibling gaps

Class: JSON GENERATE phrases named in the checklist item that were still refused. Fixed here: NAME OMITTED.
Sibling gaps (no burned-estate program uses JSON GENERATE/PARSE, so all are frontier): JSON PARSE CONVERTING and tables; COMP-1/COMP-2 floats; elementary source (IBM wrapper not stated); source that is a table; ODO table inside another table; non-ASCII output.

Cross-repo

None.

Gates

pytest test_det_json_generate / test_det_json_parse / test_det_source_4462 / test_cobolrt_api / test_cobolrt_rules: pass. audit_check.py: all clear. cobolrt_api.py --check: holds. Overlap: #7930 edits gen.py, X76 and the JSON tests; merged main in, expect a trivial rebase.

Lessons for agents

  • A new public cobolrt method needs cobolrt_api.py generate, visibility flipped to public by hand when the emitter uses it (then generate again for the summary counts), and an entry in the rule's plumbing list in cobolrt_rules.json.
  • Test statement text past column 72 is silently truncated: split phrases across lines.

🤖 Generated with Claude Code

…object (Part of #7524)

IBM's NAME phrase: OMITTED generates an anonymous JSON object whose top-level parent name is not written, and
identifier-4 must be identifier-2. Translated as the source group's {members} alone (oracle-unbacked, register X76);
OMITTED on any other item stays refused by name; JSON PARSE keeps refusing it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 18:56
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 18:57
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot disabled auto-merge November 6, 2026 19:27
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This PR conflicts with main, so no checks ran. Merge origin/main into it and regenerate generated files with their tools (never hand-merge them), then push.

@squid-shepherd squid-shepherd Bot added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Nov 6, 2026
…843Z

# Conflicts:
#	docs/language_status/cobolrt_api.json
@squid-shepherd squid-shepherd Bot removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CI shepherd: the head of this PR (63dfb30) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then). Until then it is a draft and runs the cheap audits only; re-adding the label marks it ready, which starts the full set on that head.

@squid-shepherd
squid-shepherd Bot marked this pull request as draft November 6, 2026 19:37
@squid-shepherd squid-shepherd Bot added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md labels Nov 6, 2026
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

1 similar comment
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 19:41
@squid-shepherd squid-shepherd Bot added the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 19:42
@squid-shepherd squid-shepherd Bot removed the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd
squid-shepherd Bot disabled auto-merge November 6, 2026 20:38
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This PR conflicts with main, so no checks ran. Merge origin/main into it and regenerate generated files with their tools (never hand-merge them), then push.

@squid-shepherd squid-shepherd Bot added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Nov 6, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-shepherd squid-shepherd Bot removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CI shepherd: the head of this PR (47ff972) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then). Until then it is a draft and runs the cheap audits only; re-adding the label marks it ready, which starts the full set on that head.

@squid-shepherd
squid-shepherd Bot marked this pull request as draft November 6, 2026 20:43
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CI shepherd: the head of this PR (47ff972) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then). Until then it is a draft and runs the cheap audits only; re-adding the label marks it ready, which starts the full set on that head.

@squid-shepherd squid-shepherd Bot added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md labels Nov 6, 2026
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot marked this pull request as ready for review November 6, 2026 20:45
@squid-shepherd squid-shepherd Bot added the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@squid-shepherd
squid-shepherd Bot enabled auto-merge (squash) November 6, 2026 20:46
@squid-protocol squid-protocol added shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md labels Nov 6, 2026
@squid-shepherd

squid-shepherd Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant