Repository navigation
[Bug]: Link Routing description in Settings → Browser is not localized #9442
Description
Activity
Repro (source) — confirmed on current HEAD
Root cause.
getBrowserLinkRoutingDescription()insrc/renderer/src/components/settings/browser-search.tsbuilds the description with a hard-coded English template literal and never callstranslate():return `Open http(s) links in Orca's built-in browser — from the terminal, markdown, and the editor. ${getBrowserLinkRoutingShortcutLabel(platform)} always uses your system browser.`
Sibling entries in the same file all go through
translate(...), so only this description stays English under non-English UI locales. The string never enters the i18n catalog.Steps
- Set UI language to Korean (or any non-English locale).
- Settings → Browser.
- Title is localized (e.g. "링크 라우팅"); description stays English (quoted above).
Open fix PR: #9444. Reusable notes:
tools/repro-9442-link-routing-i18n/.Correction to my earlier closure: #9442 is the original report; #9652 is its duplicate. Keeping #9442 as the canonical issue and closing it as completed removes the circular duplicate references.
The localization change landed in merged PR #10991; #9444 was closed without merging. Current main routes the Link Routing description through translate() with catalog entries and platform-specific shortcut interpolation. The focused localization tests pass (2 tests). #9652 will be linked here with GitHub’s native Duplicate reason.
- marked [Bug]: "Link Routing" setting description stays in English under Korean UI #9652 as a duplicate of this issue
on Oct 9, 2026
Operating system
macOS
Orca version
1.4.146
Details
Short summary:
With a non-English UI language (e.g. Korean), the "Link Routing" description in Settings → Browser always renders in English, while every other string on the pane is localized.
What happened?
The Link Routing row's title is localized ("링크 라우팅"), but its description stays English:
Why (from reading the code):
getBrowserLinkRoutingDescription()insrc/renderer/src/components/settings/browser-search.tsbuilds this copy with a template literal (it interpolates the platform-specific shortcut label), so it never goes throughtranslate()— the other five entries in the same file are all wrapped. The localization codemod that wrapped renderer strings only classifies string literals in user-visible positions (JSX attributes,title:/description:object properties, …), so a template literal returned from a plain function was never a candidate. The string is hard-coded English regardless of locale, and since it never enters the catalog, the translation pipeline can't pick it up either.How can we reproduce it?