Skip to content

[Bug]: "Link Routing" setting description stays in English under Korean UI #9652

Closed as duplicate
Closed as duplicate
[Bug]: "Link Routing" setting description stays in English under Korean UI#9652
Assignees
brennanb2025
Labels
bugSomething isn't workinghas_reproConclusive reproduction exists (test/script/CLI evidence). See docs/bug-reproductions/

Description

@seandoesdev
seandoesdev
opened on Jul 21, 2026

Operating system

Windows (also affects macOS/Linux — the string is platform-independent)

Orca version

v1.4.147-rc.4

Details

Short summary:
In Settings → Workflow → Browser, the "Link Routing" title is localized, but its description text stays in English even when the UI language is set to a non-English locale (e.g. Korean).

What happened?
The description reads:

Open http(s) links in Orca's built-in browser — from the terminal, markdown, and the editor. {shortcut} always uses your system browser.

in English regardless of the selected UI language, while every other string on the same pane is translated.

How can we reproduce it?

  1. Set the UI language to Korean (Settings → Appearance → interface language).
  2. Go to Settings → Workflow → Browser.
  3. The "Link Routing" description below the title is shown in English.

Anything else that might help:
Root cause: getBrowserLinkRoutingDescription() in src/renderer/src/components/settings/browser-search.ts returns a hardcoded template literal, so the string never enters the i18n catalog and is never translated. Every other entry in that file goes through translate(). The platform-specific shortcut label (⇧⌘-click / Shift+Ctrl+click) is interpolated into the sentence, which is likely why it was hardcoded.

Activity

  1. AmethystLiang
    assigned
    brennanb2025
    on Jul 21, 2026
  2. nwparker
    added
    bugSomething isn't working
    on Jul 27, 2026

  3. nwparker commented on Jul 27, 2026

    @nwparker
    nwparker
    on Jul 27, 2026
    Contributor

    Reproduction status: has_repro (code-level; tree @ current REPRO)

    Same root cause as #9442 (already has_repro). getBrowserLinkRoutingDescription() still returns a hard-coded English template with no translate().

    Evidence

    src/renderer/src/components/settings/browser-search.ts:

    export function getBrowserLinkRoutingDescription(platform: BrowserShortcutPlatform): string {
  return `Open http(s) links in Orca's built-in browser — from the terminal, markdown, and the editor. ${getBrowserLinkRoutingShortcutLabel(platform)} always uses your system browser.`
}

    Sibling entries in the same file all use translate(...). Title "Link Routing" is localized; description never enters the catalog.

    Re-run

    rg -n "getBrowserLinkRoutingDescription" src/renderer/src/components/settings/browser-search.ts
# UI: set language KO → Settings → Workflow → Browser → description stays English

    Doc: docs/bug-reproductions/9652-link-routing-i18n.md · harness: tools/repro-9442-link-routing-i18n/

  4. nwparker
    added
    has_reproConclusive reproduction exists (test/script/CLI evidence). See docs/bug-reproductions/
    on Jul 27, 2026

  5. nwparker commented on Aug 23, 2026

    @nwparker
    nwparker
    on Aug 23, 2026
    Contributor

    Closing as a duplicate of #9442.
    Disagree? Please respond! I will re-visit this ticket in 5 days. If you respond, I will re-open it 🙏.

  6. nwparker
    closed this as not plannedon Aug 23, 2026
  7. nwparker
    closed this as a duplicateof [Bug]: Link Routing description in Settings → Browser is not localized #9442 on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghas_reproConclusive reproduction exists (test/script/CLI evidence). See docs/bug-reproductions/

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions