Repository navigation
test(claude): pass the prompt registry the child-work drain now requires - #25063
Closed
brennanb2025 wants to merge 1 commit into
Closed
brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
This was referenced Oct 3, 2026
Merged
Merged
This was referenced Oct 4, 2026
Merged
Contributor
Author
|
Superseded: main's claude-child-work-evidence-retention.test.ts now passes the prompt registry (landed on main separately), which is why this PR conflicts. No longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two changes that landed on main a day apart don't fit together, so the type check for the main (Node) part of the app fails on main and on every pull request tested against it. This fixes the one test that broke. The app itself is unchanged.
What Changed
The problem. #22634 (merged 2026-10-03) changed
drainClaudeChildWorkinsrc/main/claude/claude-child-work-evidence.tsso it also reads the session's prompt registry (prompts). #24707 (merged 2026-10-02) had added a test,src/main/claude/claude-child-work-evidence-retention.test.ts, that callsdrainClaudeChildWorkwith onlychildWorkandtranslator. Each PR passed CI on its own. Combined on main, the Node type check reports:CI type-checks a PR merged with main, so every open PR's
typecheckjob fails on this line. CI's script stops at the first project that fails, so the web and CLI type checks never get to run either.User-facing change: none. Only a test changes.
The mechanism. The test now passes a fresh
ClaudePromptRegistry, built the same way production builds one when a session starts (claude-structured-session-acquisition.ts). The test is about how much child output is kept, not about prompts, so an empty registry is enough.Why
Giving the test the argument the function now requires is the whole fix. Making
promptsoptional again would weaken the type #22634 added on purpose.Linked Issue
None (maintainer fix for a type error on main).
Visual Proof
N/A: test-only change, nothing visible.
Testing
I manually tested these changes locally
Automated tests added/updated, or explained why not below
vitest run --config config/vitest.config.ts src/main/claude/claude-child-work-evidence-retention.test.ts: 3/3 pass. They passed before the change too: vitest doesn't type-check, so only the type check can show this fix.oxfmt and oxlint on the changed file: clean.
Not run locally: the type check (it runs through a shared gate on this machine). CI's
typecheckjob on this PR is the check that matters.Review
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
Test-only change: no security, platform, SSH, mobile, compatibility, or performance impact.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)