Repository navigation
fix(test): pass getInsertionRange in the image-insert access test - #25351
Merged
Merged
Conversation
9 tasks done
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main's typecheck is red: two PRs that landed close together disagree about one test argument. This updates the test to the new argument.
What Changed
rich-markdown-image-insert.test.ts: the "declares document-folder access" test passedinsertPos: 4, which #25176 replaced withgetInsertionRange. It now passesgetInsertionRange: () => ({ from: 4, to: 4, requestOrder: 1 }), the same value the file's other tests use. Test-only.Why
#24489 added the test after #25176 changed the function's arguments, so
pnpm run typecheckfails on main and on every open PR's CI.Linked Issue
Maintainer PR; fixes main's typecheck (TS2353 in rich-markdown-image-insert.test.ts).
Visual Proof
N/A: test-only change.
Testing
pnpm run typecheckpasses.rich-markdown-image-insert.test.ts: 7/7 pass.I manually tested these changes locally
Automated tests added/updated, or explained why not below
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)