[CI] Fix main CI chat test contract and line-limit failures

[nwparker]

Superseded by the main CI repairs already merged in #25933 and #25949. Closed to avoid duplicating their fixes.

ELI5

Main's checks fail in two unchanged chat tests, blocking unrelated sidebar fixes.

What Changed

Pass the current { items } argument to the thinking-state reader in two existing assertions. Move the mobile disclosure test's existing render harness into a named test fixture so the test stays below its line limit. All assertions and harness defaults are retained.

Why

These repair stale test callers and an oversized test file at their sources, without weakening lint rules or changing application behavior.

Linked Issue

Internal maintenance; found while validating the sidebar collapse fixes.

Visual Proof

N/A — test-only changes; application behavior is unchanged. The sidebar fixes will have separate before/after proof.

Testing

• Automated checks run locally: full pnpm tc; full pnpm exec oxlint --format github; changed-code quality gate.
• Existing shared test: 17 passed. Existing mobile disclosure test: 21 passed.
• macOS local verification; repository CI covers the remaining platform checks.

Review

The extracted harness has identical props, defaults, and hook invocation. No assertions, limits, or suppressions were removed.

Agent skill upstream boundary

• Not applicable; no upstream skill source copied.

Checklist

• Small and focused; cause, mechanism, and choice explained.
• Visual proof applicability stated.
• Self-reviewed; no runtime, SSH, path, shortcut, or cross-platform behavior change.
• Typecheck, lint, and focused tests pass locally; build is unchanged and CI will check it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0703a296-969c-43a3-8d17-92c3c29fe7ec

📥 Commits

Reviewing files that changed from the base of the PR and between 07981bd and bba5d28.

📒 Files selected for processing (3)

• mobile/src/session/mobile-native-chat-turn-disclosure-test-harness.ts
• mobile/src/session/use-mobile-native-chat-turn-disclosure.test.tsx
• src/shared/structured-agent-session-live-turn.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The PR adds an exported mobile disclosure test harness and updates the mobile disclosure tests to import it instead of defining it locally. It also changes two reasoning-state tests to provide rows through an { items: [...] } input. The expected results for running and completed reasoning remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to bba5d

The test harness extraction preserves the existing disclosure scenarios, and the reasoning tests now use the reader’s expected input shape. No merge-blocking behavior change was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the CI test-contract and line-limit fixes described in the changes.
Description check	✅ Passed	The description explains the changes, their purpose, testing, visual-proof applicability, and review context. It identifies the work as internal maintenance, which aligns with the template’s exception…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}