Repository navigation
fix(test): restore main typecheck — pass resolveLaunchArgs in the record store slot test - #25970
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe chat-host setup test now supplies an empty launch-argument list through Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change supplies the required resolver for a store-and-teardown test; the inspected path does not launch sessions or omit saved arguments, so no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ELI5
Main does not typecheck. Two PRs merged close together: #25721 made
resolveLaunchArgsa required runtime dependency, and #24934 added a test that builds the runtime without it. Each was green alone; together they breakpnpm tc, which fails every PR's "static analysis and typecheck" job.What Changed
Test-only: the new test in
src/main/runtime/agent-session-record-store-slot.test.tsnow passesresolveLaunchArgs: () => [], matching every other test that builds these deps.Why
Smallest change that restores a green main; no product code changes.
Linked Issue
N/A — main-breakage fix from the #25721 + #24934 merge interaction.
Visual Proof
N/A — test-only typecheck fix.
Testing
pnpm tcpasses (failed on main before with TS2741).vitest run src/main/runtime/agent-session-record-store-slot.test.ts: 5/5 pass.I manually tested these changes locally
Automated tests added/updated, or explained why not below