Repository navigation
fix(native-chat): drop the duplicate now key left by crossing fixes - #28599
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
left red (#28603) * fix(i18n): drop the setup-only keys #28543 removed from en.json Main's localization catalog check fails on these three stale keys in es/fr/ja/ko/zh. * test(runtime): give the default-tab agent fixture a store #28543 reads settings before creating default tabs (setup-only skips them), so a storeless runtime now fails provisioning with runtime_unavailable. * fix(native-chat): restore the option write's clock both crossing fixes removed #28543 and #28599 each dropped one of the duplicate now keys, leaving none.
Summary
Main's lint fails:
structured-agent-session-message-options.tshasnowtwice because #28571 and #28577 both added it (oxlint: Duplicate key 'now').Before / after
Before: lint fails on every PR. After: one
now: () => context.now()(the #28577 form). Both entries read the same clock, so behavior is unchanged.Mechanism
Deletes the second
now: context.nowline from #28571.Why this approach
Both are equivalent; keeping #28577's line leaves that PR's diff intact.
Testing
One-line deletion of a duplicate object key; CI covers lint/typecheck/tests.