Skip to content

fix(native-chat): drop the duplicate now key left by crossing fixes - #28599

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-duplicate-now-key
Oct 14, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-duplicate-now-key

Conversation

@nwparker

@nwparker nwparker commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1

Summary

Main's lint fails: structured-agent-session-message-options.ts has now twice because #28571 and #28577 both added it (oxlint: Duplicate key 'now').

Before / after

Before: lint fails on every PR. After: one now: () => context.now() (the #28577 form). Both entries read the same clock, so behavior is unchanged.

Mechanism

Deletes the second now: context.now line from #28571.

Why this approach

Both are equivalent; keeping #28577's line leaves that PR's diff intact.

Testing

One-line deletion of a duplicate object key; CI covers lint/typecheck/tests.

#28571 and #28577 both added the clock; oxlint fails on the duplicate key.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 07bb549c-4fea-4a63-b489-b9b793d14900
📥 Commits

Reviewing files that changed from the base of the PR and between 5eda0a0 and e4caa94.

📒 Files selected for processing: 1
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-options.ts
💤 Files with no reviewable changes: 1
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-options.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The option-write context now exposes now through a closure that calls context.now().

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e4caa

The duplicate key is removed without changing the timestamp source. No actionable merge risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the lint failure, the one-line fix, the retained behavior, and the testing plan. It does not include the required linked issue, and it does not provide the full template secti… Add an actual issue link after Fixes #. Complete the required template sections, or mark non-applicable sections explicitly. State N/A with a reason for visual proof if there is no visual or interaction change.
Passed Passed checks: 4 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the native-chat fix and the removal of the duplicate now key.
Full details: Description check

Explanation

The description explains the lint failure, the one-line fix, the retained behavior, and the testing plan. It does not include the required linked issue, and it does not provide the full template sections or explicitly state N/A for visual proof.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 294927e into main Oct 14, 2026
32 checks passed
@nwparker
nwparker deleted the nwparker/fix-duplicate-now-key branch October 14, 2026 06:13
Jinwoo-H added a commit that referenced this pull request Oct 14, 2026
…s removed

#28543 and #28599 each dropped one of the duplicate now keys, leaving none.
Jinwoo-H added a commit that referenced this pull request Oct 14, 2026
 left red (#28603)

* fix(i18n): drop the setup-only keys #28543 removed from en.json

Main's localization catalog check fails on these three stale keys in es/fr/ja/ko/zh.

* test(runtime): give the default-tab agent fixture a store

#28543 reads settings before creating default tabs (setup-only skips them), so a storeless runtime now fails provisioning with runtime_unavailable.

* fix(native-chat): restore the option write's clock both crossing fixes removed

#28543 and #28599 each dropped one of the duplicate now keys, leaving none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant