Repository navigation
fix(ssh): bind relay-era legacy coordinators to their host and cap inbox reads (STA-10765 follow-up) - #29596
Merged
Conversation
… reads, and name orchestration in the reset notice (STA-10765)
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
This is a small hardening follow-up to #29571, which lets terminals started by an older Orca on an SSH host run
orca orchestrationcommands again. It closes two remaining gaps from that PR's security review and fixes one settings message.What Changed
orca orchestration inbox --limit Nfrom a relay-era terminal is clamped to between 1 and 100 rows. Before, the value went straight into the SQLLIMIT, where a negative number means "every row" and a huge one is unbounded.Why
Both code changes are narrow checks at the bridge's existing admission point (
legacy-relay-cli-caller.tsandlegacy-relay-cli-server.ts). Nothing else changes for other callers.Linked Issue
Linear STA-10765 (follow-up to #29571).
Visual Proof
N/A. The only UI change is the wording of an existing settings notice.
Testing
New tests fail on main and pass here: a coordinator record made from another host is refused;
--limit -1,1000000000and0reach the database as 1, 100 and 1. All 84 bridge tests pass, along withpnpm tc:nodeandcheck:code-quality:changed. Codex (gpt-6.1-sol, high) found no issues.Agent skill upstream boundary
Checklist