[codex] Use local regtest tx status for channel confirmations - #716
[codex] Use local regtest tx status for channel confirmations#716caydyan wants to merge 2 commits into
Conversation
|
Updated this PR to make the regtest confirmation lookup visible and stable in the UI: computed inactive-channel confirmation counts are now written back to the channel store, and the parent channel poll preserves those counts instead of resetting them on the next refresh. The Bitcoind tag selection now also follows the lightning node's linked Btc node when available. Validation run locally:
I also ran npm run check. It still fails on existing repo-wide Svelte/TypeScript diagnostics outside this PR's touched files, including app/src/api/swarm.ts, app/src/Flow.svelte, app/src/Boltwall.svelte, app/src/Jarvis.svelte, app/src/components/NodeVersionupdater.svelte, app/src/controls/Controller.svelte, and app/src/nodes/NodeStats.svelte. |
|
Follow-up pushed in Additional scope:
Validation on the current head:
|
|
Reran validation on the same head 347bbc9 after the transient GHCR-dependent test result noted above. Current local result:
The earlier dock::tests::test_ghcr_version_check failure was from an external GHCR version lookup returning empty version fields during that run; it did not reproduce on rerun. Working tree is clean after removing build output noise. |
Fixes #182.
This fixes the CLN channel confirmation display when the stack runs on regtest. The channel UI was asking mempool.space for the funding transaction, which does not work for local regtest channel funding transactions.
Changes:
GetTransactionStatuscommand backed by local bitcoind RPCgetrawtransactionplus block header lookupValidation:
cargo checkcargo test --lib(21 passed)npm run buildgit diff --checkrustfmt --edition 2021 --check src/conn/bitcoin/bitcoinrpc.rs src/cmd.rsNote:
npm run checkstill fails on existing unrelated repo-wide Svelte/TypeScript diagnostics in files such asapi/swarm.ts,Flow.svelte,Boltwall.svelte,Jarvis.svelte,NodeVersionupdater.svelte, andNodeStats.svelte; I did not touch those paths. Repo-widecargo fmt --checkalso reports pre-existing formatting drift outside the touched Rust files, so I validated the touched Rust files directly.Bounty note: this PR is intended for the Sphinx 350,000 sat bounty attached to issue #182. BTC payout address:
bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc.