Add ticket tribe notification link - #1622
Open
caydyan wants to merge 2 commits into
Open
Conversation
Author
|
Follow-up pushed in This keeps the requested ticket tribe notification link behavior and tightens the edge cases:
Validation:
|
Author
|
Dependency install succeeded on a rerun, so I was able to run the focused local validation for the current head 7c6c6b3. Validation now passing locally:
The earlier blocker was dependency installation network retries; no code change was needed for this validation pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses stakwork/sphinx-relay#429 by adding the requested explanatory tribe notification link below the bounty action buttons when a sponsoring tribe is available.
The link text is:
It reuses the existing tribe redirect handler, so it opens the same sponsoring tribe destination as the current tribe action button.
Validation
git diff --checksrc/bounties/__tests__/BountyModelButtonSet.spec.tsxfor rendering and clicking the new link.Blocked locally:
npm test -- --runTestsByPath src/bounties/__tests__/BountyModelButtonSet.spec.tsx --runInBand --no-coverage --silentcould not run in this fresh checkout becausenode_modules/.bin/jestwas unavailable. Twoyarn install --frozen-lockfile --ignore-scriptsattempts stalled in repeated package fetch retries, including a retry with--registry https://registry.npmjs.org --network-timeout 600000.Bounty
Issue title advertises
$@50000. If accepted for bounty payout, route BTC/sats to:bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc