Repository navigation
appletbdrm: unpark the T1 panel on resume - #49
niconistal wants to merge 1 commit into
Conversation
appletbdrm_t1_park() sets HID feature report 3 to mode 1 at suspend, but resume never set it back. The rearm handshake succeeds and frames are accepted, yet the T1 keeps the panel parked, so the Touch Bar stays dark until a reboot. End the T1 rearm with a report-3 write of mode 2. It runs before the DRM state is restored, so the panel receives fresh frames after the unpark. A failed write takes the existing display-interface reprobe path. The resume fault tests cover the new step. Tested on a MacBookPro14,3 with s2idle. Before this change, report 3 read mode 1 and the panel was dark after every resume. With the change, report 3 read mode 2 after each of 10 timer wakes, and the panel was seen lit after one of them and after a lid close. S3 on the 14,2 is not covered. Refs standardagents#18 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The failed
On Rust 1.98.1, Options: pin the toolchain in CI, allow |
|
Suggestion: Edit 2026-10-21 Read this first How to install t1-touchbar.service Fix: Touch Bar dark after S3 suspend/resume on T1 MacBook Pros (2016–2017, MacBookPro13,x/14,x) After every S3 resume the Touch Bar stays dark, and no HID-level revival works — the T1 The root cause: the T1's rendering subsystem needs a firmware-level wake call after 1. Wake call via acpi_call (requires the 2. Call it from a systemd resume unit ( 3. Disable USB runtime suspend for the iBridge via udev (otherwise the T1 falls This matches the failure signature reported in several threads since 2017 (HID writes
Full write-up: mythopoeic/macbookpro14-3-linux#2 |
|
One more data point for this change, from a second MacBookPro14,3. It uses the stock Omarchy kernel, without the s2idle patches from omacom/omarchy-pkgs#596 and #544. Setup
Result without a fix (both tests)
The update from 0.1.11 to 0.1.12 and from 7.2.5 to 7.2.8 did not change the result. Result with the awake write When I write report 3 = Until this PR is in a release, I use a systemd sleep hook in About the S3 suggestion above Two items in the udev rule and the unit need a correction before other users copy them:
|
|
edited my comment. Added missing instructions for t1-touchbar.service and missing '=' |
|
MacBookPro14,2, stock t1bridge 0.1.12-1, Omarchy 4.5.0-3, kernel After two deep suspends the strip was dark and report 3 byte 1 was Details are on #18. No SOCW call. |
|
Follow-up to the 14,2 note above. With report 3 already |
|
Additional s2idle hardware confirmation for this patch on MacBookPro14,3 (2017 15-inch, i7-7820HQ, Radeon Pro 560, T1 The earlier local diagnosis reproduced the parked-panel failure: report 3 remained in mode 1 after a PM transition, and an explicit mode-2 request plus fresh renderer frames relit the strip. I then rebuilt T1Bridge 0.1.12 DKMS with this PR's change at On November 6, the patched driver was present for an attended real lid-close/open s2idle cycle on a separately built
The host also needed separate Thunderbolt/BCM43602 fixes from omacom/omarchy-pkgs#596, omacom/omarchy-pkgs#544 (ACPICA), an EC wake-capability workaround, and T1 USB remote wake disabled. Those host requirements are not fixed by this display patch. This was one short real lid cycle with the final successful combination, not a repeated-cycle, official-package, or long-term qualification. Camera, ALS and Touch ID were not separately acceptance-tested after this cycle. No SOCW/FRST call or T1 firmware recovery was used for this resume. This evidence supports the existing s2idle scope and does not contradict the separate S3 cases where mode 2 alone leaves the strip dark. It also does not close all of #18. Prepared with AI assistance from local build/test records and the machine owner's separate visual confirmation. No new hardware test was run for this comment. |
On a MacBookPro14,3, the Touch Bar stays dark after every system resume until a reboot.
appletbdrm_t1_park()sets HID feature report 3 to mode 1 at suspend, and nothing sets it back. The rearm handshake succeeds and frames are accepted, but the T1 keeps the panel parked.This change ends
appletbdrm_t1_rearm()with a report-3 write of mode 2 (appletbdrm_t1_unpark()). It runs beforedrm_mode_config_helper_resume(), so the panel gets fresh frames after the unpark. A failed write takes the existing display-interface reprobe path from #27. The resume fault tests now include the new step.Testing
MacBookPro14,3 (Radeon Pro 555 on the panel), T1Bridge 0.1.12 DKMS rebuilt with this patch, kernel 7.2.5 (
linux-omarchyplus the s2idle patches from omacom/omarchy-pkgs#596 and #544), Omarchy 4.0.4,mem_sleep_default=s2idle.03 01 …) after every resume, and the panel stayed dark. Restartingt1-touchbar-hwor the renderer, or runningt1bridge validate usb-cycle, did not relight it.03 02and then restarting the renderer relit it.make qualitypasses.Scope
docs/display-failures.mdnow records the s2idle result separately.Refs #18
🤖 Generated with Claude Code