Conversation
Collaborator
Author
|
@gthopkins things that this PR could use from you (either edits to this PR or a separate PR after merging this one):
@adw96 things this PR could use from you:
|
Contributor
|
@svteichman having made my edits as you suggested, I'm going to merge this, and @gthopkins can add more tests / vignettes/ any other input at any time. Thank you for the AMAZING vignette -- it was even better than I expected, and I SO appreciate you doing it. ❤️❤️❤️ I'm very grateful... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ndFit()andest_nuis())ndFitoutputndFit()so thatAandXare formulas and adataargument is included (addressing issue wishlist: IO #3)Xis not included or is the intercept model returnsPsi1andPsi1gestimates, otherwise returnsPsi2andPsi2g