feat: add visual identity service#2550
Merged
Merged
Conversation
|
Hey @osmaczko, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Pull Request Checklist
|
Member
Jenkins BuildsClick to see older builds (12)
|
osmaczko
force-pushed
the
feat/emojihash
branch
2 times, most recently
from
3fe3301 to
c410fbc
Compare
Contributor
Author
|
Thank you @richard-ramos, learned a lot! |
3 tasks
| } | ||
|
|
||
| func (api *API) EmojiHashOf(pubkey string) (hash []string, err error) { | ||
| log.Info("[VisualIdentityAPI::EmojiHashOf]") |
Member
There was a problem hiding this comment.
Probably we can change this to .Debug or .Trace (if it exists), since it might pollute the logs too much
richard-ramos
approved these changes
Mar 9, 2022
serhanwbahar
approved these changes
Mar 10, 2022
Member
|
tested in status-im/status-app#5020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: status-im/status-app#4736, status-im/status-app#4951
Related specs: status-im/specs#166