feat(@desktop): use emoji hash and identicon ring#5020
Merged
Conversation
Member
Jenkins BuildsClick to see older builds (9)
|
iurimatias
requested changes
Mar 11, 2022
Member
iurimatias
left a comment
iurimatias
left a comment
There was a problem hiding this comment.
The mentions still show the old identicons
Member
|
@iurimatias I recommend doing those in another issue/PR. The contact section will also be needed, but I'm currently working on moving the Contacts view and improving it, so to avoid conflicts, it would be better to go step by step. Also, this PR is already quite bigé |
Member
|
@jrainville alright fair enough |
iurimatias
approved these changes
Mar 11, 2022
Member
|
needs rebase |
osmaczko
force-pushed
the
feat/emojihash-identiconring
branch
from
93cbc4c to
7ed1e2f
Compare
iurimatias
force-pushed
the
feat/emojihash-identiconring
branch
from
7ed1e2f to
26bcdd5
Compare
jrainville
reviewed
Mar 14, 2022
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Very nice work.
I added a couple of comments. None of them are game breaking, but it would be nice to "fix" them.
osmaczko
force-pushed
the
feat/emojihash-identiconring
branch
from
187780f to
ded7eb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4782
status-im/status-go#2550
Video of functionality
visual_identity-2022-03-10_19.51.08.mp4