[16827] Disable transparent video looping by ibrkhalil · Pull Request #17000 · status-im/status-legacy

ibrkhalil · 2023-08-12T13:05:19Z

fixes #16827
status: ready

status-im-auto · 2023-08-12T13:12:49Z

Jenkins Builds

Click to see older builds (47)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`4e74f16`	#2	2023-08-12 13:12:49	~6 min	`android`	🤖`apk` 📲
✔️	`4e74f16`	#2	2023-08-12 13:12:51	~6 min	`ios`	📱`ipa` 📲
✔️	`4e74f16`	#2	2023-08-12 13:12:53	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`4e74f16`	#2	2023-08-12 13:15:56	~9 min	`tests`	📄`log`

❌	`13b5d37`	#3	2023-08-12 14:41:37	~22 sec	`android`	📄`log`
❌	`13b5d37`	#3	2023-08-12 14:41:38	~23 sec	`android-e2e`	📄`log`

❌	`a0c497b`	#4	2023-08-12 14:42:01	~20 sec	`ios`	📄`log`
❌	`a0c497b`	#4	2023-08-12 14:42:10	~30 sec	`android-e2e`	📄`log`
❌	`a0c497b`	#4	2023-08-12 14:42:12	~31 sec	`android`	📄`log`

❌	`0df8dc6`	#5	2023-08-12 14:45:09	~19 sec	`android`	📄`log`
❌	`0df8dc6`	#5	2023-08-12 14:45:10	~19 sec	`android-e2e`	📄`log`
❌	`0df8dc6`	#5	2023-08-12 14:45:29	~39 sec	`ios`	📄`log`

❌	`f47e1e0`	#6	2023-08-12 14:47:11	~21 sec	`android-e2e`	📄`log`
❌	`f47e1e0`	#6	2023-08-12 14:47:17	~26 sec	`android`	📄`log`
❌	`f47e1e0`	#6	2023-08-12 14:47:28	~38 sec	`ios`	📄`log`

✔️	`d8adbfa`	#7	2023-08-12 14:56:57	~7 min	`android`	🤖`apk` 📲
✔️	`d8adbfa`	#7	2023-08-12 14:56:58	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d8adbfa`	#7	2023-08-12 14:59:26	~9 min	`tests`	📄`log`
✔️	`d8adbfa`	#7	2023-08-12 15:08:43	~18 min	`ios`	📱`ipa` 📲

✔️	`f2b792d`	#10	2023-08-14 16:55:02	~5 min	`android-e2e`	🤖`apk` 📲
❌	`f2b792d`	#10	2023-08-14 16:55:48	~6 min	`ios`	📄`log`
✔️	`f2b792d`	#10	2023-08-14 16:55:58	~6 min	`android`	🤖`apk` 📲
✔️	`f2b792d`	#10	2023-08-14 16:57:33	~8 min	`tests`	📄`log`

✔️	`1067a54`	#11	2023-08-15 16:33:42	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`1067a54`	#11	2023-08-15 16:33:43	~6 min	`android`	🤖`apk` 📲
✔️	`1067a54`	#11	2023-08-15 16:36:22	~8 min	`tests`	📄`log`
❌	`1067a54`	#11	2023-08-15 16:48:24	~20 min	`ios`	📄`log`

❌	`deb1b21`	#12	2023-08-15 17:22:11	~20 sec	`tests`	📄`log`
❌	`deb1b21`	#12	2023-08-15 17:22:12	~20 sec	`android`	📄`log`
❌	`deb1b21`	#12	2023-08-15 17:22:16	~29 sec	`android-e2e`	📄`log`
❌	`deb1b21`	#12	2023-08-15 17:22:31	~40 sec	`ios`	📄`log`

❌	`d5b7000`	#13	2023-08-15 18:09:03	~4 min	`tests`	📄`log`
✔️	`d5b7000`	#13	2023-08-15 18:11:04	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`d5b7000`	#13	2023-08-15 18:11:16	~6 min	`android`	🤖`apk` 📲
✔️	`d5b7000`	#13	2023-08-15 18:19:37	~14 min	`ios`	📱`ipa` 📲

❌	`e072157`	#14	2023-08-15 19:04:20	~2 min	`tests`	📄`log`
✔️	`e072157`	#14	2023-08-15 19:07:31	~5 min	`android`	🤖`apk` 📲
✔️	`e072157`	#14	2023-08-15 19:07:48	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`e072157`	#14	2023-08-15 19:12:32	~10 min	`ios`	📱`ipa` 📲
❌	`e072157`	#15	2023-08-15 19:37:13	~2 min	`tests`	📄`log`
❌	`e072157`	#16	2023-08-16 00:11:23	~2 min	`tests`	📄`log`
❌	`e072157`	#17	2023-08-16 06:00:41	~2 min	`tests`	📄`log`
❌	`e072157`	#18	2023-08-16 06:09:11	~2 min	`tests`	📄`log`

✔️	`2616a2f`	#15	2023-08-16 06:15:26	~5 min	`android`	🤖`apk` 📲
✔️	`2616a2f`	#15	2023-08-16 06:16:33	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2616a2f`	#19	2023-08-16 06:19:38	~9 min	`tests`	📄`log`
✔️	`2616a2f`	#15	2023-08-16 06:22:58	~12 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0322a1f`	#16	2023-08-16 15:43:03	~6 min	`android`	🤖`apk` 📲
✔️	`0322a1f`	#16	2023-08-16 15:43:42	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0322a1f`	#20	2023-08-16 15:45:22	~9 min	`tests`	📄`log`
✔️	`0322a1f`	#16	2023-08-16 15:56:06	~19 min	`ios`	📱`ipa` 📲

✔️	`d8d2506`	#17	2023-08-19 18:54:32	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`d8d2506`	#17	2023-08-19 18:54:41	~5 min	`android`	🤖`apk` 📲
✔️	`d8d2506`	#21	2023-08-19 18:57:44	~8 min	`tests`	📄`log`
✔️	`d8d2506`	#17	2023-08-19 19:01:03	~11 min	`ios`	📱`ipa` 📲

status-im-auto · 2023-08-16T09:16:38Z

84% of end-end tests have passed

Total executed tests: 43
Failed tests: 7
Passed tests: 36

IDs of failed tests: 702732,703133,702948,702745,702786,702731,702808

Failed tests (7)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
`Test is not run, e2e blocker` [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:439: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:177: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_hashtag_links_to_community_channels, id: 702948
`Test is not run, e2e blocker` [[reason: [NOTRUN] Can't invite user to closed community https://github.com//issues/16968]]
2. test_community_mentions_push_notification, id: 702786
# STEP: Admin gets push notification with the mention and tap it Device 1: Getting PN by 'user_1' `critical/test_public_chat_browsing.py:1082: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:177: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Push notification with the mention was not received by admin` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 7.611083984375 percents `critical/chats/test_1_1_public_chats.py:1129: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:177: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (36)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_discovery, id: 703503
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-08-16T10:03:27Z

33% of end-end tests have passed

Total executed tests: 3
Failed tests: 2
Passed tests: 1

IDs of failed tests: 702745,702786

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 8.126627604166666 percents `critical/chats/test_1_1_public_chats.py:1129: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:177: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_mentions_push_notification, id: 702786

# STEP: Admin gets push notification with the mention and tap it
Device 1: Getting PN by 'user_1'

critical/test_public_chat_browsing.py:1082: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin

Device sessions

Device 1:

Device 2:

Passed tests (1)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-08-16T10:57:13Z

Hey @ibrkhalil, thanks for the fix, looks good to me!
Passing the PR on to Francesca for design review 👁️ 👁️

ibrkhalil force-pushed the fix/16827 branch from f3c7ab1 to 4e74f16 Compare August 12, 2023 13:06

ibrkhalil force-pushed the fix/16827 branch 2 times, most recently from f47e1e0 to d8adbfa Compare August 12, 2023 14:49

ibrkhalil mentioned this pull request Aug 12, 2023

Extra frames at the end of the "Generating keys" animation #16827

Closed

ibrkhalil changed the title ~~Fix/16827~~ [16827] Disable tranparent video looping Aug 12, 2023

ibrkhalil self-assigned this Aug 13, 2023

ibrkhalil changed the title ~~[16827] Disable tranparent video looping~~ [16827] Disable transparent video looping Aug 13, 2023

ibrkhalil marked this pull request as ready for review August 15, 2023 17:15

ibrkhalil requested review from J-Son89, Parveshdhull and briansztamfater and removed request for J-Son89 and Parveshdhull August 15, 2023 19:39

briansztamfater approved these changes Aug 16, 2023

View reviewed changes

ibrkhalil added the request-manual-qa label Aug 16, 2023

ibrkhalil added 6 commits August 16, 2023 09:09

Test

f232584

Bump version

e997f63

Bump

f1c02a9

Bump rn-transparent-video

2751604

Bump package

9cdb628

lint

2616a2f

ibrkhalil force-pushed the fix/16827 branch from e072157 to 2616a2f Compare August 16, 2023 06:09

qoqobolo self-assigned this Aug 16, 2023

J-Son89 reviewed Aug 16, 2023

View reviewed changes

Comment thread src/status_im2/contexts/onboarding/generating_keys/view.cljs

J-Son89 approved these changes Aug 16, 2023

View reviewed changes

qoqobolo added the Tested - OK label Aug 16, 2023

ibrkhalil added 2 commits August 16, 2023 18:35

Merge branch 'develop' into fix/16827

0322a1f

Merge branch 'develop' into fix/16827

d8d2506

Francesca-G approved these changes Aug 21, 2023

View reviewed changes

ibrkhalil merged commit bdfdf68 into develop Aug 21, 2023

ibrkhalil deleted the fix/16827 branch August 21, 2023 08:49

andresceballosm pushed a commit to andresceballosm/status-mobile that referenced this pull request Aug 29, 2023

[16827] Disable transparent video looping (status-im#17000)

55ea3f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16827] Disable transparent video looping#17000

[16827] Disable transparent video looping#17000
ibrkhalil merged 8 commits into
developfrom
fix/16827

ibrkhalil commented Aug 12, 2023 •

edited

Loading

Uh oh!

status-im-auto commented Aug 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

status-im-auto commented Aug 16, 2023

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Uh oh!

status-im-auto commented Aug 16, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Uh oh!

qoqobolo commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ibrkhalil commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

status-im-auto commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

Uh oh!

status-im-auto commented Aug 16, 2023

84% of end-end tests have passed

Failed tests (7)

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (36)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Uh oh!

status-im-auto commented Aug 16, 2023

33% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (1)

Class TestGroupChatMultipleDeviceMergedNewUI:

Uh oh!

qoqobolo commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ibrkhalil commented Aug 12, 2023 •

edited

Loading

status-im-auto commented Aug 12, 2023 •

edited

Loading