Skip to content

[16827] Disable transparent video looping #17000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibrkhalil merged 8 commits into from
Aug 21, 2023
Merged

[16827] Disable transparent video looping #17000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f232584
Test
ibrkhalil Aug 12, 2023
e997f63
Bump version
ibrkhalil Aug 14, 2023
f1c02a9
Bump
ibrkhalil Aug 14, 2023
2751604
Bump rn-transparent-video
ibrkhalil Aug 15, 2023
9cdb628
Bump package
ibrkhalil Aug 15, 2023
2616a2f
lint
ibrkhalil Aug 15, 2023
0322a1f
Merge branch 'develop' into fix/16827
ibrkhalil Aug 16, 2023
d8d2506
Merge branch 'develop' into fix/16827
ibrkhalil Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@
"react-native-randombytes": "^3.6.1",
"react-native-reanimated": "2.11.0",
"react-native-redash": "^16.0.11",
"react-native-svg": "13.10.0",
"react-native-shake": "^3.3.1",
"react-native-share": "^8.2.2",
"react-native-static-safe-area-insets": "^2.2.0",
"react-native-status-keycard": "git+https://github.com/status-im/react-native-status-keycard.git#refs/tags/v2.5.39",
"react-native-svg": "13.10.0",
"react-native-touch-id": "^4.4.1",
"react-native-transparent-video": "git+https://github.com/status-im/react-native-transparent-video.git#refs/tags/0.0.9",
"react-native-transparent-video": "git+https://github.com/status-im/react-native-transparent-video.git#refs/tags/0.1.1",
"react-native-webview": "git+https://github.com/status-im/react-native-webview.git#refs/tags/v11.16.0-status",
"react-syntax-highlighter": "^15.5.0",
"rn-emoji-keyboard": "0.7.0",
Expand Down
10 changes: 6 additions & 4 deletions src/status_im2/common/parallax/view.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[status-im2.common.parallax.style :as style]))

(defn f-sensor-animated-video
[{:keys [offset stretch order source disable-parallax?]}]
[{:keys [offset stretch order source disable-parallax? enable-looping?]}]
(let [double-stretch (* 2 stretch)
{window-width :width
window-height :height} (rn/get-window)
Expand All @@ -25,14 +25,15 @@
image-style]}
[transparent-video/view
{:source source
:style style/video}]])))
:style style/video
:loop enable-looping?}]])))

(defn sensor-animated-video
[props]
[:f> f-sensor-animated-video props])

(defn f-video
[{:keys [layers disable-parallax? offset stretch container-style]
[{:keys [layers disable-parallax? offset stretch container-style enable-looping?]
:or {offset 50
stretch 0}}]
[rn/view
Expand All @@ -44,7 +45,8 @@
:offset offset
:stretch stretch
:order (inc idx)
:disable-parallax? disable-parallax?}])
:disable-parallax? disable-parallax?
:enable-looping? enable-looping?}])
layers)])

(defn video
Expand Down
3 changes: 2 additions & 1 deletion src/status_im2/contexts/onboarding/generating_keys/view.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
:container-style {:top 40
:left 20}
:layers (:generate-keys resources/parallax-video)
:disable-parallax? true}]
:disable-parallax? true
:enable-looping? false}]
Comment thread
ibrkhalil marked this conversation as resolved.
[:f> f-page-title insets]])

(defn f-simple-page
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9012,9 +9012,9 @@ react-native-touch-id@^4.4.1:
resolved "https://registry.yarnpkg.com/react-native-touch-id/-/react-native-touch-id-4.4.1.tgz#8b1bb2d04c30bac36bb9696d2d723e719c4a8b08"
integrity sha512-1jTl8fC+0fxvqegy/XXTyo6vMvPhjzkoDdaqoYZx0OH8AT250NuXnNPyKktvigIcys3+2acciqOeaCall7lrvg==

"react-native-transparent-video@git+https://github.com/status-im/react-native-transparent-video.git#refs/tags/0.0.9":
"react-native-transparent-video@git+https://github.com/status-im/react-native-transparent-video.git#refs/tags/0.1.1":
version "0.1.0"
resolved "git+https://github.com/status-im/react-native-transparent-video.git#97d8c773eae82851b170b53c9fc13020f74eefe7"
resolved "git+https://github.com/status-im/react-native-transparent-video.git#1327fc622f7521269f66299c3aca610494c76fe1"

"react-native-webview@git+https://github.com/status-im/react-native-webview.git#refs/tags/v11.16.0-status":
version "11.16.0"
Expand Down