ci: fix create-release commitish input (was target_commitish)#2866
Conversation
|
PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-7d2e5a91f0ff65f8f7e9 (SDF collaborators only — install instructions in the release description) |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow that automatically opens (and reuses) a standing forward-port PR from emergency-release into master whenever emergency-release contains commits not yet in master, preventing hotfixes from being forgotten off the mainline.
Changes:
- Add
.github/workflows/forwardPort.ymlto trigger on pushes toemergency-release. - Add a guard step to skip PR creation when there are no unported commits (
git rev-list --count origin/master..HEAD). - Use
gh pr create(withGITHUB_TOKEN) to open the forward-port PR, skipping if one is already open.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
piyalbasu
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd403a9250
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0bdeb58a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
actions/create-release@v1's input is `commitish`, not `target_commitish`, so
the value was silently ignored ("Unexpected input(s) 'target_commitish'") and
release tags were created against the repo default branch (master) instead of
the built ref. This put 5.42.1-beta.1's tag on master's HEAD rather than the
emergency-release commit it was built from. Use the correct key so beta/prod
release tags point at the actual built commit.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
piyalbasu
force-pushed
the
ci/forward-port-emergency-release
branch
from
22505e5 to
99870ba
Compare
piyalbasu
changed the title
| draft: false | ||
| prerelease: false | ||
| target_commitish: ${{ steps.checkout_sha.outputs.sha }} | ||
| commitish: ${{ steps.checkout_sha.outputs.sha }} |
There was a problem hiding this comment.
this change is cosmetic and actually doesn't do anything - it's just to use the same param as submitBeta
TL;DR
Fixes a typo in the beta/production release workflows so the GitHub Release tag attaches to the commit that was actually built, instead of the input being silently ignored.
Implementation details (for agents)
actions/create-release@v1's input iscommitish, nottarget_commitish. The wrong key was silently ignored (Unexpected input(s) 'target_commitish'), so the API defaulted the new tag to the repo's default branch (master) instead ofsteps.checkout_sha.outputs.sha.submitBeta.yml— real fix:create-release@v1creates the tag, so the wrong key put beta tags onmaster's HEAD rather than the built ref (observed with5.42.1-beta.1, which had to be repointed manually).submitProduction.yml— the tag is pre-created in an earlierCreate and push git tagstep, socommitishis effectively a no-op here; corrected for consistency so the two workflows match.Only the
actions/create-release@v1steps were touched; nosoftprops/action-gh-releaseor REST usages (which legitimately usetarget_commitish).Note: the forward-port automation that was originally part of this PR has been removed and parked on
parked/forward-port-workflow— it needs a non-GITHUB_TOKENidentity (PAT/GitHub App) so the auto-opened PR triggers required status checks before it's viable.