Skip to content

ci: fix create-release commitish input (was target_commitish) #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piyalbasu merged 3 commits into from
Jun 26, 2026
Merged

ci: fix create-release commitish input (was target_commitish) #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99870ba
ci: fix create-release input (target_commitish -> commitish)
piyalbasu Jun 22, 2026
ba1ad3a
Merge branch 'master' into ci/forward-port-emergency-release
piyalbasu Jun 22, 2026
ee8af6f
Merge branch 'master' into ci/forward-port-emergency-release
piyalbasu Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/submitBeta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
github.event.inputs.version }}
draft: false
prerelease: true
target_commitish: ${{ steps.checkout_sha.outputs.sha }}
commitish: ${{ steps.checkout_sha.outputs.sha }}
- name: Upload Release Asset
id: upload-release-asset
uses: actions/upload-release-asset@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/submitProduction.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
body: ${{ steps.package_version.outputs.version }}
draft: false
prerelease: false
target_commitish: ${{ steps.checkout_sha.outputs.sha }}
commitish: ${{ steps.checkout_sha.outputs.sha }}

@piyalbasu piyalbasu Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is cosmetic and actually doesn't do anything - it's just to use the same param as submitBeta

- name: Build for Firefox
id: web-ext-build
uses: kewisch/action-web-ext@fe10addf5d5e5ba6b78ffde720dd488a27d10e8c #v1
Expand Down
Loading