refactor: place instance-specific config into dedicated context#997
Closed
Gtoasted wants to merge 13 commits into
Closed
refactor: place instance-specific config into dedicated context#997Gtoasted wants to merge 13 commits into
Gtoasted wants to merge 13 commits into
Conversation
The purpose of this context is to hold information about a single instance of stoat (information that is currently stored in global configuration) Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
…A_URL Signed-off-by: Gtoasted <git@gtoasted.de>
…Y_URL Signed-off-by: Gtoasted <git@gtoasted.de>
…BOX_URL Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
…TCHA_SITEKEY Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
Signed-off-by: Gtoasted <git@gtoasted.de>
don't know why the previous commits didn't Signed-off-by: Gtoasted <git@gtoasted.de>
Gtoasted
force-pushed
the
refactor-config
branch
from
ed49810 to
91ba97a
Compare
This was referenced Mar 7, 2026
Author
|
These changes are already merged in #999, so to reduce pr clutter I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to implement token federation (as per https://github.com/orgs/stoatchat/discussions/1073#discussioncomment-15814999), the client must be refactored to not use global configuration for values that are dependent on a specific instance.
This is fairly easy for most of them, since they are accessed in components and can thus use solid's context feature, but some values are also accessed in stores. I'm not sure how to best make those access the config, and I would appreciate suggestions, but I believe they will lead to a few client errors at worst, so it should be fine to deal with them later.