fix(smithy): update codex interactive sandbox flag#116
Open
furquanuddin94 wants to merge 1 commit into
Open
Conversation
furquanuddin94
force-pushed
the
codex/codex-workspace-write-flag
branch
from
d671a42 to
0e26f1a
Compare
Extract the Codex interactive argument construction into buildCodexInteractiveArgs so the unit test exercises the same production arg-building logic used by spawn instead of duplicating that logic in the test. The helper preserves the existing working-directory, resume, and model behavior. Codex now documents --sandbox workspace-write as the replacement for the deprecated --full-auto shortcut, so use the documented sandbox flag for fresh and resumed interactive sessions. Refs stoneforge-ai#114.
furquanuddin94
force-pushed
the
codex/codex-workspace-write-flag
branch
from
0e26f1a to
9baf6e9
Compare
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--full-autousage with the documented--sandbox workspace-writeflag.buildCodexInteractiveArgsso the unit test exercises the production arg-building logic instead of duplicating it.Fixes #114.
Test Plan
bun test packages/smithy/src/providers/codex/provider.bun.test.tscorepack pnpm --filter @stoneforge/smithy typecheckgit diff --check