Repository navigation
M6: persist fonts owned by a document - #1441
Closed
Guillergood wants to merge 1 commit into
Closed
Guillergood wants to merge 1 commit into
Guillergood wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Member
|
Thank you for the work on this. The reference tool doesn't embed fonts in documents, nothing in the app adds one, and the change reaches every font lookup and the layout cache key. Missing fonts are meant to go through the shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts portable font persistence and document scopes from #1334 for the owner's font-policy decision. Native documents, versions and branches retain bounded font bytes and ownership, with validation and warnings for missing or invalid data. No font assets or downloads are added.
Font selection is scoped to the document for measurement, canvas rendering (including parallel bands), SVG, PDF and Android XML export. Invalid members consume the shared read budget; the unused global-registration helper is removed. Regression coverage includes ownership, malformed archives, isolation and read budgets.
Draft pending owner approval of embedded fonts and licensing policy.
Validation: full cargo xtask ci passed on Windows (formatting, clippy, workspace tests, layers, attribution, localization and WASM). Uses the CI-pinned external craft-fonts input at 43913056; no font files are added.
Live-session font transfer and published-library font packaging are outside this native-document persistence change.