Skip to content

M6: persist fonts owned by a document - #1441

Closed
Guillergood wants to merge 1 commit into
storytold:mainfrom
Guillergood:codex/portable-fonts
Closed

Guillergood wants to merge 1 commit into
storytold:mainfrom
Guillergood:codex/portable-fonts

Conversation

@Guillergood

Copy link
Copy Markdown
Contributor

Extracts portable font persistence and document scopes from #1334 for the owner's font-policy decision. Native documents, versions and branches retain bounded font bytes and ownership, with validation and warnings for missing or invalid data. No font assets or downloads are added.

Font selection is scoped to the document for measurement, canvas rendering (including parallel bands), SVG, PDF and Android XML export. Invalid members consume the shared read budget; the unused global-registration helper is removed. Regression coverage includes ownership, malformed archives, isolation and read budgets.

Draft pending owner approval of embedded fonts and licensing policy.

Validation: full cargo xtask ci passed on Windows (formatting, clippy, workspace tests, layers, attribution, localization and WASM). Uses the CI-pinned external craft-fonts input at 43913056; no font files are added.

Live-session font transfer and published-library font packaging are outside this native-document persistence change.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bflatastic

Copy link
Copy Markdown
Member

Thank you for the work on this. The reference tool doesn't embed fonts in documents, nothing in the app adds one, and the change reaches every font lookup and the layout cache key. Missing fonts are meant to go through the shared craft-font-store instead. Closing.

@bflatastic bflatastic closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants