Repository navigation
M4: keep long words whole in fixed text boxes - #1442
Closed
Guillergood wants to merge 1 commit into
Closed
Guillergood wants to merge 1 commit into
Guillergood wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Member
|
Thank you for the work on this. In a fixed-width box the reference tool breaks a word that is too long for the line, rather than letting it overhang the box. Changing that would also re-flow existing files. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the long-word behavior change requested on #1334. A word wider than a fixed text box overhangs until a natural break opportunity; whitespace, punctuation and CJK opportunities keep wrapping. This preserves words in fixed boxes from external design documents.
This changes rendering of existing native documents that relied on forced mid-word breaks. Kept as a draft for a separate behavior decision. Includes a regression covering one word and a word followed by another word.
Validation: full cargo xtask ci passed on Windows (formatting, clippy, workspace tests, layers, attribution, localization and WASM). Uses the CI-pinned external craft-fonts input at 43913056; no font files are added.