deprecate roles_logic_sv2, benches, error_handling, utils::bip32_derivation#1947
Merged
plebhash merged 12 commits intoOct 17, 2025
Merged
Conversation
Shourya742
reviewed
Oct 15, 2025
plebhash
reviewed
Oct 15, 2025
plebhash
reviewed
Oct 15, 2025
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
5 times, most recently
from
72f542b to
2d5a3a7
Compare
lucasbalieiro
commented
Oct 15, 2025
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
2d5a3a7 to
edf0508
Compare
lucasbalieiro
changed the title
roles_logic_sv2 and benches
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
edf0508 to
f00304b
Compare
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
f00304b to
633908d
Compare
Shourya742
reviewed
Oct 17, 2025
…d adapt where needed Co-authored-by: GitGab19 <gabriele.vernetti@protonmail.com>
…crates.io versions of protocol crates instead of local workspace versions. This allows these components to use the deprecated roles_logic_sv2 while the rest of the workspace continues with local implementations. - Add crates.io protocol dependencies (roles_logic_sv2, codec_sv2, etc.) - Update imports to use direct crate references - Use network_helpers_sv2 and rpc_sv2 from crates.io - Configure stratum-apps to exclude core/network features for jd_serverRefactor transa0ction validation logic Co-authored-by: GitGab19 <gabriele.vernetti@protonmail.com>
…mutex::Mutex` and adapt where needed
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
633908d to
1b86032
Compare
plebhash
reviewed
Oct 17, 2025
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
65f8e97 to
32513af
Compare
lucasbalieiro
changed the title
roles_logic_sv2 and benchesroles_logic_sv2, benches, error_handling, utils::bip32_derivation
Shourya742
reviewed
Oct 17, 2025
Member
Shourya742
left a comment
Shourya742
left a comment
There was a problem hiding this comment.
@lucasbalieiro protocol/fuzz-test, has a dependency on roles-logic-sv2, can you update that.
lucasbalieiro
force-pushed
the
drop-roles-logic-sv2
branch
from
32513af to
b00ad96
Compare
Collaborator
Author
@Shourya742, thanks. Done! |
Shourya742
approved these changes
Oct 17, 2025
This was referenced Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1940
To be merged AFTER #1931
bencheserror_handlingutils::bip32_derivationDrops
roles_logic_sv2by:Refactoring
roles::jd-client,roles::pool, androles::translatorto no longer depend onroles_logic_sv2::error.Updating
jd-serverandroles::test-utils::mining-deviceto use crates from crates.io.roles_logic_sv2::handlers, and their refactor is already planned.roles_logic_sv2in the codebase just for them.Moving
roles_logic_sv2::utils::Mutextoroles::stratum-apps::custom_mutex::Mutex.