move key-utils and error-handling as modules of stratum-apps#1951
Closed
GitGab19 wants to merge 5 commits into
Closed
move key-utils and error-handling as modules of stratum-apps#1951GitGab19 wants to merge 5 commits into
key-utils and error-handling as modules of stratum-apps#1951GitGab19 wants to merge 5 commits into
Conversation
Member
Author
|
I had to add efc78bf to unblock the semver check on CI: https://github.com/stratum-mining/stratum/actions/runs/18557093752/job/52897061182?pr=1951. The error there is due to a manual publish of But given we are gonna deprecate |
GitGab19
force-pushed
the
key-utils-error-handling-modules
branch
from
e1e1428 to
2c92d3f
Compare
… crates instead of stratum-apps
GitGab19
force-pushed
the
key-utils-error-handling-modules
branch
from
2c92d3f to
a629f9c
Compare
…s.io versions of protocol crates instead of local workspace versions. This allows these components to use the deprecated roles_logic_sv2 while the rest of the workspace continues with local implementations. - Add crates.io protocol dependencies (roles_logic_sv2, codec_sv2, etc.) - Update imports to use direct crate references - Use network_helpers_sv2 and rpc_sv2 from crates.io - Configure stratum-apps to exclude core/network features for jd_server
GitGab19
force-pushed
the
key-utils-error-handling-modules
branch
from
a629f9c to
93c1209
Compare
Member
Author
|
@lucasbalieiro cherry-picked the main commit of this PR (2e340cd) and added it to #1947, adapting it to larger context there. So, I'm closing this PR in favor of #1947. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #1931.
This PR moves
key-utilsanderror-handlingintostratum-apps, dropping their crates.This should also help the work by @lucasbalieiro on #1947.