migrate mining_sv2::Target to bitcoin::Target#1950
Merged
Conversation
Collaborator
|
Hi, @icarusmaximal. Thanks for the contribution. We can see that your PR needs to be So we can check if the CI passes on the changes you made and proceed with the review |
Contributor
Author
|
I'll be on it once I'm back. Out of station currently. |
d6712c7 to
b3c05fb
Compare
b3c05fb to
813417d
Compare
Member
|
force-pushing here to expedite merging
|
813417d to
9913fa8
Compare
9913fa8 to
95a700c
Compare
plebhash
approved these changes
Oct 22, 2025
Member
|
thanks for your contribution @icarusmaximal moving forward, please be careful when committing the ones we have committed on the repo have but if you build with a recent compiler, that will get changed into |
This was referenced Oct 22, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Nov 13, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Nov 14, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Nov 14, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 11, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 11, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 12, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 13, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #1834