Skip to content

migrate mining_sv2::Target to bitcoin::Target#1950

Merged
plebhash merged 2 commits into
stratum-mining:mainfrom
icarusmaximal:target_migration
Oct 22, 2025
Merged

migrate mining_sv2::Target to bitcoin::Target#1950
plebhash merged 2 commits into
stratum-mining:mainfrom
icarusmaximal:target_migration

Conversation

@icarusmaximal
Copy link
Copy Markdown
Contributor

addresses #1834

@lucasbalieiro
Copy link
Copy Markdown
Collaborator

Hi, @icarusmaximal. Thanks for the contribution.

We can see that your PR needs to be rebased. Could you do it?

So we can check if the CI passes on the changes you made and proceed with the review

@icarusmaximal
Copy link
Copy Markdown
Contributor Author

I'll be on it once I'm back. Out of station currently.

@plebhash
Copy link
Copy Markdown
Member

force-pushing here to expedite merging

  • avoid changing version field of test/integration-tests/Cargo.lock
  • bump mining_sv2 MAJOR to v6.0.0 (without bumping any PATCH of dependent crates, because none of them have been published on the last PATCH yet... see Remove binary codec sv2 #1952 (comment))

@plebhash
Copy link
Copy Markdown
Member

thanks for your contribution @icarusmaximal

moving forward, please be careful when committing Cargo.lock files

the ones we have committed on the repo have version = 3, which abides by MSRV 1.75

but if you build with a recent compiler, that will get changed into version = 4 and break MSRV CI

@plebhash plebhash merged commit 52f9d13 into stratum-mining:main Oct 22, 2025
11 checks passed
This was referenced Oct 22, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Nov 13, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Nov 14, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Nov 14, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 11, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 11, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 12, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 13, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants