clarify new_shares_sum field of SubmitShares.Success#126
Merged
plebhash merged 2 commits intoFeb 20, 2026
Merged
Conversation
plebhash
changed the title
new_shares_sum field of SubmitShares.Success
plebhash
force-pushed
the
2025-04-04-clarify-submit-shares-success
branch
2 times, most recently
from
87d8db6 to
8a56281
Compare
Contributor
|
Thanks for adding these graphics, it makes things way easier to understand! |
plebhash
force-pushed
the
2025-04-04-clarify-submit-shares-success
branch
2 times, most recently
from
9f44b3b to
592112a
Compare
plebhash
referenced
this pull request
in vinteumorg/pleblottery
Jun 16, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
plebhash
force-pushed
the
2025-04-04-clarify-submit-shares-success
branch
from
592112a to
ce15cb7
Compare
it's not clear what the `new_shares_sum` field of `SubmitShares.Success` really means after reaching out to @jakubtrnka , he described the following: > `new_submits_accepted_count` is number of submits. > `new_shares_sum` is "integral" over difficulty of work to be confirmed by this success msg this commit clarifies both `SubmitShares.Success` and `SubmitShares.Error` with detailed descriptions and new visual diagrams.
…f `SubmitShares.Success`
plebhash
force-pushed
the
2025-04-04-clarify-submit-shares-success
branch
from
ce15cb7 to
5e37f3e
Compare
plebhash
changed the title
new_shares_sum field of SubmitShares.Successnew_shares_sum field of SubmitShares.Success
Member
Author
|
marking this as ready for review, as we're getting confusion around this concept stratum-mining/stratum#2090 (comment) |
Contributor
|
ack |
1 similar comment
Collaborator
|
ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #125
Markdown rendering of my fork