chore(streaming): remove VNC code path, Selkies-only#261
Merged
Conversation
Selkies-GStreamer (WebRTC) is the only supported streaming protocol going
forward. The dual-protocol VNC code path is removed.
Deleted:
- api/internal/handlers/vnc_proxy.go VNC WebSocket proxy handler
- api/internal/handlers/vnc_proxy_test.go its tests
- api/static/vnc-viewer.html noVNC client static page
- agents/k8s-agent/agent_vnc_handler.go VNC message handler in agent
- agents/k8s-agent/agent_vnc_tunnel.go VNC port-forward tunnel manager
- tests/scripts/phase{1,4}/test_*_vnc_*.sh VNC test scripts
Removed routes:
- /api/v1/vnc/:sessionId (VNC proxy)
- /api/v1/vnc-viewer/:sessionId (noVNC iframe page)
- /api/v1/websockify/* (websockify path)
Renamed agent ↔ control-plane protocol fields for protocol-agnostic naming:
- StatusMessage.VNCReady → StatusMessage.StreamingReady (json: streamingReady)
- StatusMessage.VNCPort → StatusMessage.StreamingPort (json: streamingPort)
- AgentStatusUpdate.VNCReady → AgentStatusUpdate.StreamingReady
- AgentStatusUpdate.VNCPort → AgentStatusUpdate.StreamingPort
- TemplateConfig.VNCPort → TemplateConfig.StreamingPort
- Removed: MessageTypeVNCData, MessageTypeVNCClose, MessageTypeVNCReady,
MessageTypeVNCError; VNCDataMessage, VNCReadyMessage, VNCCloseMessage,
VNCErrorMessage; agent's vnc_data/vnc_close message dispatch.
Updated:
- DB defaults flipped from 'vnc'/5900 to 'selkies'/8080 across 8 query sites
- StreamingProtocol field doc comment updated (selkies-only)
- Auth middleware + security headers strip the /vnc/, /vnc-viewer/, /websockify/
proxy-path special cases; only /api/v1/http/ remains
- Agent sends streamingReady=(state == "running") and streamingPort=8080
- agent_websocket constructs streamingURL=/api/v1/http/<id>/ instead of vncURL
- UI SessionViewer collapses the dual-protocol iframe branch to Selkies-only
- ui/src/lib/api.ts + ui/src/mocks/handlers.ts updated to selkies/8080
- api/Dockerfile no longer copies static/ (the static dir is gone)
- sessiontemplates.go default port 3000 → 8080
Verified: api / agents/k8s-agent / agents/docker-agent / ui all build;
api + websocket + handlers tests pass.
Note: ~100 docs/ + ADR + e2e-spec files still mention VNC. Those are
historical-context references and are deferred to the docs/wiki phase
(Phase 6 of the cleanup plan).
github-actions
Bot
added
testing
component:backend
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selkies-GStreamer (WebRTC) is the only supported streaming protocol going forward. The dual-protocol VNC code path is removed.
Deleted
Removed routes: `/api/v1/vnc/:sessionId`, `/api/v1/vnc-viewer/:sessionId`, `/api/v1/websockify/*`.
Renamed agent ↔ control-plane protocol fields (protocol-agnostic naming)
Other updates
Verified
Deferred to the docs/wiki phase
~100 references to VNC remain in `docs/`, ADRs, README/CHANGELOG/ROADMAP, GitHub issue templates, helm chart docs, and several E2E spec files. None affect compilation or behavior; they're historical-context references and will be reconciled in Phase 6 of the cleanup plan (docs + wiki rebuild).