Skip to content

chore(streaming): remove VNC code path, Selkies-only #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaAFerguson merged 1 commit into from
Apr 25, 2026
Merged

chore(streaming): remove VNC code path, Selkies-only #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 13 additions & 28 deletions agents/k8s-agent/agent_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,6 @@ func (h *StartSessionHandler) Handle(cmd *CommandMessage) (*CommandResult, error
// Don't fail the command - Session CRD is informational
}

// Initialize VNC tunnel for this session
if h.agent != nil {
if err := h.agent.initVNCTunnelForSession(sessionID); err != nil {
log.Printf("[StartSessionHandler] Warning: Failed to init VNC tunnel: %v", err)
// Don't fail the command - VNC can be established later
}
}

// v2.0 ARCHITECTURE: Update database via API (source of truth)
// Send session update message to Control Plane to update database
if h.agent != nil {
Expand All @@ -160,14 +152,14 @@ func (h *StartSessionHandler) Handle(cmd *CommandMessage) (*CommandResult, error
return &CommandResult{
Success: true,
Data: map[string]interface{}{
"sessionId": sessionID,
"deployment": deployment.Name,
"service": service.Name,
"pvc": pvcName,
"podName": podName,
"podIP": podIP,
"vncPort": 3000, // Default VNC port
"state": "running",
"sessionId": sessionID,
"deployment": deployment.Name,
"service": service.Name,
"pvc": pvcName,
"podName": podName,
"podIP": podIP,
"streamingPort": 8080, // Selkies-GStreamer default
"state": "running",
},
}, nil
}
Expand Down Expand Up @@ -209,13 +201,6 @@ func (h *StopSessionHandler) Handle(cmd *CommandMessage) (*CommandResult, error)

log.Printf("[StopSessionHandler] Deleting resources for session %s (deletePVC: %v)", sessionID, shouldDeletePVC)

// Close VNC tunnel for this session
if h.agent != nil && h.agent.vncManager != nil {
if err := h.agent.vncManager.CloseTunnel(sessionID); err != nil {
log.Printf("[StopSessionHandler] Warning: Failed to close VNC tunnel: %v", err)
}
}

// Delete Deployment
if err := deleteDeployment(h.kubeClient, h.config.Namespace, sessionID); err != nil {
log.Printf("[StopSessionHandler] Warning: Failed to delete deployment: %v", err)
Expand Down Expand Up @@ -340,11 +325,11 @@ func (h *WakeSessionHandler) Handle(cmd *CommandMessage) (*CommandResult, error)
return &CommandResult{
Success: true,
Data: map[string]interface{}{
"sessionId": sessionID,
"podName": podName,
"podIP": podIP,
"vncPort": 3000,
"state": "running",
"sessionId": sessionID,
"podName": podName,
"podIP": podIP,
"streamingPort": 8080,
"state": "running",
},
}, nil
}
Expand Down
6 changes: 0 additions & 6 deletions agents/k8s-agent/agent_message_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ func (a *K8sAgent) handleMessage(messageBytes []byte) error {
case "shutdown":
return a.handleShutdownMessage(msg.Payload)

case "vnc_data":
return a.handleVNCDataMessage(msg.Payload)

case "vnc_close":
return a.handleVNCCloseMessage(msg.Payload)

default:
log.Printf("[K8sAgent] Unknown message type: %s", msg.Type)
return nil
Expand Down
172 changes: 0 additions & 172 deletions agents/k8s-agent/agent_vnc_handler.go
View file
Open in desktop

This file was deleted.

Loading
Loading