chore(drift): remove dead looks_open var; pin the intentional asymmetry#368
Merged
Conversation
The defect scan flagged `looks_open` (F841 — assigned, never used; dead since the initial commit). It was the CLOSED-side trigger of an early symmetric draft (`gh CLOSED and looks_open`); the shipped broad check `not looks_closed` is a strict superset of it, so removing the variable changes no behavior. Drift detection is asymmetric on purpose: CLOSED is terminal (broad — a closed issue whose row doesn't read closed is drift), OPEN is not (narrow — only an explicit closed marker contradicts it). A symmetric `not looks_open` open-side would false-positive every in-progress row. - drift.py: drop the dead var; comment the why of the asymmetry. - test_drift.py: 4 tests pinning the previously-untested OPEN side + ambiguous-body cases, so nobody "restores symmetry" back into noise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Full-repo defect scan flagged
looks_openinlib/drift.py(ruff F841 — dead since the initial commit). It was the CLOSED-side trigger of an early symmetric draft (gh CLOSED and looks_open); the shippednot looks_closedis a strict superset, so removing it changes no behavior.The broad/narrow split is intentional: CLOSED is terminal (broad — anything not-closed is drift), OPEN is not (narrow — only an explicit closed marker contradicts it; a broad
not looks_openopen-side would false-positive every🚧 in-progressrow).Changes
lib/drift.py— remove the dead var; comment the why of the asymmetry.tests/test_drift.py— 4 tests pinning the previously-untested OPEN side + ambiguous-body cases.Test plan
tests.test_drift7/7 (3 existing + 4 new); ruff F841 cleared on drift.py; full suite 1120 pass.No behavior change — dead-code removal + coverage of existing behavior.
🤖 Generated with Claude Code