Repository navigation
Conversation
This was referenced Nov 17, 2026
Farhad-Shabani
approved these changes
Nov 19, 2026
| spn-network-types = { git = "https://github.com/succinctlabs/network", branch = "main", features = ["network"] } | ||
| spn-pricing = { git = "https://github.com/succinctlabs/network", branch = "main" } | ||
| spn-utils = { git = "https://github.com/succinctlabs/network", branch = "main" } | ||
| spn-artifacts = { git = "https://github.com/succinctlabs/network", branch = "tobias/cap-artifact-download-size" } |
Collaborator
There was a problem hiding this comment.
just a reminder to get it back to the "main" branch before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROGRAM_TOO_LARGE. The request does not stay assigned until its deadline.spn-*crates point at the branch of feat(artifacts): cap the size of a download from a URI network#251, which adds the size limit to the download function.Motivation
This answers a review comment on #214. The fulfiller reads the full program into memory before a worker checks its size. A requester controls that size, so one very large upload can use all the memory of the fulfiller. The fulfiller then restarts and reads the same program again.
The limit is the same
max_bytesvalue that the artifact clients use, so the fulfiller and the workers refuse the same programs.Validation
PROGRAM_TOO_LARGE.cargo testfor the fulfillment, fulfiller and artifact crates passes. Clippy with the CI flags,cargo fmt --checkandcargo deny checkpass.Caveats
spn-*crates must point atbranch = "main"again after feat(artifacts): cap the size of a download from a URI network#251 merges. CI fails when that branch is deleted, so this cannot be missed.max_bytesvalue. Today that is the program only.