♿(Modal) h2 titles, dialog aria-labelledby, i18n close button#390
Open
Ovgodd wants to merge 1 commit into
Open
♿(Modal) h2 titles, dialog aria-labelledby, i18n close button#390Ovgodd wants to merge 1 commit into
Ovgodd wants to merge 1 commit into
Conversation
03d9772 to
96c34ba
Compare
aria-labelledby on h2, describedby on subtitle, i18n close/back, popover label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve Modal accessibility :
Proposal
h2and name the dialog witharia-labelledbywhen a title exists.aria-describedbyin the default variant when present.aria-hiddenon the icon wrapper).aria-labelon the DatePicker calendar popover.role="dialog"andaria-modal="true".