Reject profileless multiplayer peers - #5882
Merged
Alayan-stk-2 merged 1 commit intoOct 2, 2026
Merged
Conversation
acts-1631
force-pushed
the
fix-empty-profile-chat
branch
from
September 28, 2026 16:39
40676c5 to
e24bd4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerLobby::handleUnencryptedConnectionaccepted a connection with a player count of zero and marked the peer as validated without adding a player profile.handleChatlater usesgetPlayerProfiles()[0]to build the sender prefix, so a modified LAN client could send a valid connection request with no players and then crash the server with a chat message.This rejects zero-player connection requests before validation and ignores chat from peers that have no profile. Normal clients always include at least one profile, including spectators.