Skip to content

Reject profileless multiplayer peers #5882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alayan-stk-2 merged 1 commit into from
Oct 2, 2026
Merged

Reject profileless multiplayer peers #5882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/network/protocols/server_lobby.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,11 @@ bool ServerLobby::notifyEvent(Event* event)
void ServerLobby::handleChat(Event* event)
{
if (!checkDataSize(event, 1) || !ServerConfig::m_chat) return;
if (event->getPeer()->getPlayerProfiles().empty())
{
Log::warn("ServerLobby", "Ignoring chat from peer without a profile.");
return;
}

// Update so that the peer is not kicked
event->getPeer()->updateLastActivity();
Expand Down Expand Up @@ -2797,6 +2802,12 @@ void ServerLobby::handleUnencryptedConnection(std::shared_ptr<STKPeer> peer,
// if this is a pending connection
unsigned total_players = 0;
unsigned player_count = data.getUInt8();
if (player_count == 0)
{
Log::warn("ServerLobby", "Rejecting connection without a player profile.");
peer->reset();
return;
}

if (is_pending_connection)
{
Expand Down