Repository navigation
Reduce duplicate bridge quote requests - #4145
ChiTimesChi wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: synapsecns/sanguine/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4145 +/- ##
===================================================
+ Coverage 57.57648% 57.99574% +0.41926%
===================================================
Files 147 147
Lines 4217 4221 +4
Branches 809 809
===================================================
+ Hits 2428 2448 +20
+ Misses 1699 1682 -17
- Partials 90 91 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deploying sanguine-fe with
|
| Latest commit: |
5a5cd10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c5d35b7.sanguine-fe.pages.dev |
| Branch Preview URL: | https://codex-bridge-quote-rpc-load.sanguine-fe.pages.dev |
Bundle ReportChanges will increase total bundle size by 62.99kB (0.19%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sdk-router-@synapsecns/sdk-router-cjsAssets Changed:
view changes for bundle: synapse-interface-server-cjsAssets Changed:
Files in
Files in
view changes for bundle: synapse-interface-edge-server-array-pushAssets Changed:
view changes for bundle: sdk-router-@synapsecns/sdk-router-esmAssets Changed:
view changes for bundle: synapse-interface-client-array-pushAssets Changed:
Files in
Files in
|
Description
Repeated renders recreate bridge providers and SDK instances, and simultaneous identical quote requests repeat the same SDK work. Reuse providers, SDK instances, and context while the chain/RPC configuration is unchanged, and share in-flight
bridgeV2requests between consumers of the same SDK and full parameter set.Provider configuration changes, including widget custom RPC changes, still rebuild the SDK and trigger a fresh interface quote. Successful and failed requests leave the sharing map when they settle, so later refreshes fetch fresh quotes. Each thunk retains its own request ID.
Additional context
Validation
--skipLibCheck.@typescript-eslint/no-shadowrule disabled. Formatting andgit diff --checkpassed.937a238: synapse-interface preview link