Remove Secrets.xcconfig + SecretsManager system#1
Merged
Conversation
Remove the Secrets.xcconfig build configuration, the SecretsManager helper, and the internal non-accessibility-trigger dataset collection feature that depended on it (Azure upload): NonAXTriggerDatasetUploader, AzureBlobUploader, the debug labeling UI/window controller, the false-negative report button, and their hooks in the trigger service and hint view. Drop the now-unused 'hide bug report emoji' demo toggle. Clean up the project baseConfiguration references, the Secrets Check build phase step, git hooks and docs.
🔍 Onit Code Review❌ API Error (401): {"type":"error","error":{"type":"authentication_error","message":"x-api-key header is required"},"request_id":"req_011Cc6sTvDa3YZgTwxk8ZV7r"} Automated review · 4004cf6 |
Niduank
added a commit
that referenced
this pull request
Jun 17, 2026
Remove Secrets.xcconfig + SecretsManager system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the build-time
Secrets.xcconfigconfiguration, theSecretsManagerhelper, and the internal non-accessibility-trigger dataset-collection feature that depended on it (Azure upload).Removed
Secrets.xcconfig/.sample,com.synth.environment.plist.sampleSecretsManager.swiftNonAXTriggerDatasetUploader,AzureBlobUploader,NonAXTriggerLabelingView,NonAXTriggerLabelingWindowController,FalseNegativeReportButton, and their hooks in the trigger service and hint viewCleaned up
baseConfigurationreferences + the "Secrets Check" build-phase step (the "Git Hooks Check" step is kept).gitignore+CLAUDE.mdAll removed code was DEBUG/BETA-only; runtime behavior unchanged. Verified: builds green (Debug) and the app launches without crashing.