Migrate bundle identifier to inc.synth.onit.quickedit#3
Merged
Conversation
Phase 3 of the bundle-id migration (code/project only): - Update PRODUCT_BUNDLE_IDENTIFIER for the app (dev + release) and test target - Update keychain-access-groups in entitlements - Update the dev-build detection identifier - Use Bundle.main.bundleIdentifier for the QuickEdit demo state instead of a stale literal - Update the TCC reset commands in PERMISSIONS.md Firebase/Google OAuth identifiers are intentionally untouched — they require a new Firebase app and OAuth client registered for the new bundle id (external).
🔍 Onit Code Review❌ API Error (401): {"type":"error","error":{"type":"authentication_error","message":"x-api-key header is required"},"request_id":"req_011CcCJDA9UxirUXugmhN2bd"} Automated review · 7a55084 |
New Firebase app registered for inc.synth.onit.quickedit in the onit-3b9d6 project (BUNDLE_ID and GOOGLE_APP_ID updated; same project, API key and sender).
Update GIDClientID and the reversed-client URL scheme in Info.plist to the new iOS OAuth client registered for inc.synth.onit.quickedit.
- Allow overriding APP_NAME, SCHEME and SIGN_ID via env (defaults unchanged) so the script works for other Apple teams / open-source builds - Stop embedding a provisioning profile: Developer ID distribution doesn't need one, and none of the app's entitlements (team-prefixed keychain-access-groups, network, apple-events) require it. Just strip any embedded dev profile left by the automatic "Apple Development" archive before re-signing with Developer ID.
Niduank
force-pushed
the
feat/bundle-id-migration
branch
from
dbb6ea9 to
1dbea93
Compare
Set PRODUCT_NAME and CFBundleDisplayName to "QuickEdit" (was "Onit QuickEdit"), update the test host path, and the build script APP_NAME (which drives the .app, DMG and volume names). The Xcode project, scheme and module stay "OnitQuickEdit".
Change the bare "Onit" app-title labels (About page, notification window, Discord onboarding) and the "Onit Demo" demo name to "QuickEdit". Other "Onit" strings (brand / umbrella references in onboarding, billing and server messages) are left unchanged on purpose.
Default QuickEditConfig.isEnabled to true so the QuickEdit-only app has its core feature active on first launch (was false, an opt-in default inherited from the multi-feature Onit app).
- Drop macos/Onit_Developer_ID.provisionprofile from git (re-added by mistake via `git add -A`; the build script no longer uses it) and ignore *.provisionprofile / *.mobileprovision so it can't be committed again - Make the final `spctl --assess` non-fatal: it is unreliable for DMGs on recent macOS and was failing the script despite successful notarization + stapling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the app identity to the new bundle id
inc.synth.onit.quickedit(same Apple teamTYC9PKBMB6, branding unchanged).In this PR (code/project only)
PRODUCT_BUNDLE_IDENTIFIER×4 (app dev/release + test target, debug & release)keychain-access-groupsin entitlementsDevBuildDetectionService)Bundle.main.bundleIdentifierinstead of a stalecom.synth.onitliteralPERMISSIONS.mdThe branch compiles, but Google Sign-In will fail at runtime until the new identity is registered with the third parties:
inc.synth.onit.quickeditin projectonit-3b9d6, then replaceGoogleService-Info.plist(currentlyBUNDLE_ID = inc.synth.Onit).inc.synth.onit.quickedit, then updateGIDClientIDand the reversed-client URL scheme inInfo.plist.inc.synth.onit.quickedit(+.dev) with Keychain Sharing, and a new Developer ID provisioning profile.