Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,24 @@ jobs:
sips -z $double $double internal/webui/assets/logo.png --out /tmp/icon.iconset/icon_${size}x${size}@2x.png >/dev/null
done
iconutil -c icns /tmp/icon.iconset -o /tmp/AppIcon.icns
- name: Assemble Bambu Profile Manager.app for both architectures
- name: Assemble Bambu Profile Manager (bpm).app for both architectures
run: |
version="${{ github.ref_name }}"
version="${version#v}"
for arch in arm64 amd64; do
# The .app folder itself is named "Bambu Profile Manager.app"
# (that's what shows in Launchpad/Spotlight/Finder) - the release
# asset's own filename stays the technical "BpmTray_..." for a
# stable download URL across renames.
app="dist-tray/darwin_${arch}/Bambu Profile Manager.app"
# The .app folder name is what Spotlight/Launchpad actually
# match against - real bug found live: CFBundleName/
# CFBundleDisplayName in Info.plist do NOT affect Spotlight
# search at all (confirmed: mdfind found nothing for "bpm" with
# only the plist fields set, until "(bpm)" was added to the
# folder name itself). Without this, searching "bpm" - the
# product's own short name - found no match and macOS offered
# its Stocks-ticker-lookup suggestion instead, which looks like
# a real result until you click it.
#
# The release asset's own filename stays the technical
# "BpmTray_..." for a stable download URL across renames.
app="dist-tray/darwin_${arch}/Bambu Profile Manager (bpm).app"
mkdir -p "$app/Contents/MacOS" "$app/Contents/Resources"
sed "s/VERSION_PLACEHOLDER/${version}/" packaging/macos/Info.plist.template > "$app/Contents/Info.plist"
cp "dist-tray/darwin_${arch}/bpm-tray" "$app/Contents/MacOS/bpm-tray"
Expand Down
4 changes: 2 additions & 2 deletions packaging/macos/Info.plist.template
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<plist version="1.0">
<dict>
<key>CFBundleName</key>
<string>Bambu Profile Manager</string>
<string>Bambu Profile Manager (bpm)</string>
<key>CFBundleDisplayName</key>
<string>Bambu Profile Manager</string>
<string>Bambu Profile Manager (bpm)</string>
<key>CFBundleIdentifier</key>
<string>uk.syscode-labs.bpm-tray</string>
<key>CFBundleExecutable</key>
Expand Down
Loading