Feature: Support NixOS#2132
Conversation
|
Thanks for adding Nix/NixOS support. A root-level I don't think this should be merged as-is yet. The main issue is the Also, even with Could you either:
It would also be helpful to add a Nix validation step, such as |
t8y2
left a comment
There was a problem hiding this comment.
Thanks for adding Nix/NixOS support. A root-level flake.nix makes sense if DBX wants to officially support Nix users.
I don't think this should be merged as-is yet. The main issue is the dbx-web package: the flake tries to skip default Cargo features with cargoExtraArgs = "--no-default-features", but buildRustPackage does not consume that field. The supported field is buildNoDefaultFeatures = true;.
Also, even with cargo build -p dbx-web --no-default-features, dbx-core default features are still enabled because crates/dbx-web/Cargo.toml depends on dbx-core without default-features = false. That still pulls in duckdb-bundled, so the current comment/config about skipping DuckDB is misleading.
Could you either:
- remove the
dbx-webpackage from this PR and keep the scope todbx-desktop, or - fix the Cargo feature wiring and Nix build fields so
dbx-webactually builds without DuckDB?
It would also be helpful to add a Nix validation step, such as nix flake check or nix build .#dbx-desktop, otherwise this new packaging path can regress without CI coverage.
Thanks for your attention and feedback. allright, i removed dbx-web. its unnecessary. |
|
Thanks for the contribution! Merged in 894ef0c, will be released in the next version. |
变更说明
支持NixOS
变更类型
NixOS系统打包支持,不涉及dbx项目本身功能的更改。
涉及前端
无
验证
在NixOS系统的dbx项目根目录执行:
nix build .#dbx-desktop已验证成功编译。
已验证项目运行正常。
关联 Issue
无