Repository navigation
plan: UB-288 (crv_eval reads before the control points at a NaN parameter) and UB-289 (Fix_CoinVertices uses freed props pointers) - #2258
Merged
Conversation
…eter) and UB-289 (Fix_CoinVertices uses freed props pointers) UB-288: CreateOrientedTrimBoundary reverses a UV trim curve built on an edge whose limits were never set (0/0, NaN interval); sm_CrvEval then reads Pw[-1] for a degree-3 curve with two control points. Found on STEP Tools ap203/st203-bapl.stp body 0. UB-289: Fix_CoinVertices rewrites later pairs to a survivor props pointer that UpdateTargetLists has freed, so those merges depend on heap address reuse. Found on ap203/gehaeuse.stp body 0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only: two new upstream-issue records, found while tracing the remaining STEP Tools
--constructorcorpus mismatches.ap203/st203-bapl.stpbody 0, two edges keep an unset interval (SetLimitsreturns 1007 on both kernels).CreateOrientedTrimBoundarybuilds their UV trim curves and reverses the parameterization, which divides 0 by 0 and gives a NaN interval.sm_CrvEval/N_BasisFindSpanat that NaN then readPw[-1]of a degree-3 curve with two control points. C++ returns a garbage point with success, so its area "succeeds"; Rust's evaluation stops on its bounds check. This was read from the code for this input, not observed under a sanitizer. The corpus DIFF on this body stays: Rust's error is at least as good as C++'s garbage.ap203/gehaeuse.stpbody 0,Fix_CoinVerticesrewrites a merged vertex's later pairs to the survivor's props pointer afterUpdateTargetListshas freed and reallocated the props. C++ merges those pairs only when the allocator hands back the same address (as glibc did here: 226 edges / 141 vertices, against Rust's deterministic 228 / 143). It's the same class as the PR-164 finding. Rust's default stays deterministic.Counts and function names only; no geometry.
🤖 Generated with Claude Code