Replace onebox.go [wip]#10319
Draft
stephanos wants to merge 1 commit into
Draft
Conversation
6e911b9 to
d2bd371
Compare
stephanos
commented
May 18, 2026
| @@ -69,8 +59,6 @@ import ( | |||
|
|
|||
| type ( | |||
| TemporalImpl struct { | |||
Contributor
Author
There was a problem hiding this comment.
There are many more refactorings that can be done here, but keeping it to an absolute minimum here.
e935010 to
4f3cee0
Compare
832deab to
6ea1fbd
Compare
6ea1fbd to
d59e4f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR is the parent branch for removing the duplicated onebox setup and moving the remaining test customization points onto narrower testcore/testhook APIs.
Related split PR: #10336
Why?
We want to eliminate
WithFxOptionsForServicesotestcoreno longer needs an unrestricted Fx escape hatch when it moves away from duplicating the production service setup.TODO: remove
WithFxOptionsForServiceblockersSplit PRs and remaining call-site groups:
DCRedirectionPolicydecoration intests/xdc/failover_test.gowith typedWithDCRedirectionPolicy: Add test cluster DC redirection policy option #10328tests/dlq_test.goDLQ observation decoration with await-based polling: Remove one WithFxOptionsForService from tests/dlq_test.go #10338tests/dlq_test.gohistory task execution decoration with fault injection/test hooks: Remove one more WithFxOptionsForService from tests/dlq_test.go #10336TestAddTasks_GetEngineErrfunctional coverage with a focused unit test: Migrate TestAddTasks_GetEngineErr to unit test #10337tests/purge_dlq_tasks_api_test.goand replace its persistence decoration with runtime fault injection: Migrate tests/purge_dlq_tasks_api_test.go #10339tests/schedule_migration_test.gofrontendContextMetadataInterceptordecoration with a focused typedTestEnvoption backed by startup dynamic config: Replace schedule migration Fx option with dynamic config #10400.tests/xdc/history_replication_dlq_test.gohistory replication executor / DLQ writer / namespace replication executor decorations with focused test hooks or testcore options: Remove xdc history replication DLQ Fx decorations #10389DCRedirectionPolicydecorations instream_based_replication_test.goanddelete_execution_replication_test.gowithWithDCRedirectionPolicy: Use typed DC redirection policy option in xdc tests #10349TestWithFxOptionsForService, since it only verifies the generic escape hatch.testcore.WithFxOptions/WithFxOptionsForServiceAPI once all call sites are gone.How did you test it?
Validation is tracked in the split PRs above.
Rebase validation on latest main:
Potential risks
The main risk is missing one of the existing
WithFxOptionsForServicecall sites while splitting the work across smaller PRs.