Skip to content

Replace onebox.go [wip]#10319

Draft
stephanos wants to merge 1 commit into
mainfrom
stephanos/rm-onebox
Draft

Replace onebox.go [wip]#10319
stephanos wants to merge 1 commit into
mainfrom
stephanos/rm-onebox

Conversation

@stephanos
Copy link
Copy Markdown
Contributor

@stephanos stephanos commented May 18, 2026

What changed?

This PR is the parent branch for removing the duplicated onebox setup and moving the remaining test customization points onto narrower testcore/testhook APIs.

Related split PR: #10336

Why?

We want to eliminate WithFxOptionsForService so testcore no longer needs an unrestricted Fx escape hatch when it moves away from duplicating the production service setup.

TODO: remove WithFxOptionsForService blockers

Split PRs and remaining call-site groups:

How did you test it?

Validation is tracked in the split PRs above.

Rebase validation on latest main:

go test -tags test_dep ./common/testing/testhooks ./temporal ./tests/testcore ./tests -run "TestAddTasks_GetEngineErr|TestDLQSuite|TestPurgeDLQTasksSuite|TestFunctionalTestBase|TestWithFxOptionsForService" -count=1

Potential risks

The main risk is missing one of the existing WithFxOptionsForService call sites while splitting the work across smaller PRs.

@stephanos stephanos force-pushed the stephanos/rm-onebox branch 14 times, most recently from 6e911b9 to d2bd371 Compare May 18, 2026 22:56
Comment thread tests/testcore/onebox.go
@@ -69,8 +59,6 @@ import (

type (
TemporalImpl struct {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more refactorings that can be done here, but keeping it to an absolute minimum here.

@stephanos stephanos force-pushed the stephanos/rm-onebox branch 3 times, most recently from e935010 to 4f3cee0 Compare May 18, 2026 23:04
@stephanos stephanos changed the title Replace onebox.go Replace onebox.go [wip] May 18, 2026
@stephanos stephanos force-pushed the stephanos/rm-onebox branch 11 times, most recently from 832deab to 6ea1fbd Compare May 19, 2026 02:57
@stephanos stephanos force-pushed the stephanos/rm-onebox branch from 6ea1fbd to d59e4f0 Compare May 27, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant