Add test cluster DC redirection policy option#10328
Merged
Merged
Conversation
stephanos
force-pushed
the
stephanos/onebox-dc-policy
branch
from
3fc1e7f to
f624941
Compare
stephanos
force-pushed
the
stephanos/onebox-dc-policy
branch
from
f624941 to
1766d14
Compare
stephanos
commented
May 19, 2026
| fx.Provide(func() listenHostPort { return listenHostPort(host) }), | ||
| fx.Provide(func() httpPort { return mustPortFromAddress(c.FrontendHTTPAddress()) }), | ||
| fx.Provide(func() config.DCRedirectionPolicy { return config.DCRedirectionPolicy{} }), | ||
| fx.Provide(func() config.DCRedirectionPolicy { return c.dcRedirectionPolicy }), |
Contributor
Author
There was a problem hiding this comment.
eventually this be will passed to temporal/fx.go's params directly (see #10319)
temporal-nick
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Pass custom
DCRedirectionPolicydirectly instead of going throughWithFxOptionsForService.Why?
We want to eliminate
WithFxOptionsForServiceas it is blocking us from migrating away from theonebox.goapproach (which duplicates the fx setup) since we don't want to expose an equivalent method intemporal/fx.go.