Remove one more WithFxOptionsForService from tests/dlq_test.go#10336
Open
stephanos wants to merge 1 commit into
Open
Remove one more WithFxOptionsForService from tests/dlq_test.go#10336stephanos wants to merge 1 commit into
stephanos wants to merge 1 commit into
Conversation
stephanos
force-pushed
the
stephanos/onebox-testhooks
branch
11 times, most recently
from
a5d1270 to
8065d96
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/onebox-testhooks
branch
3 times, most recently
from
a4f956a to
72aa7e0
Compare
stephanos
commented
May 20, 2026
| func (d {{$decorator}}) {{$method.Declaration}} { | ||
| err = d.generator.generate("{{ $method.Name }}").inject(func() error { | ||
| {{- $request := (index $method.Params 1) }} | ||
| err = d.generator.generate("{{ $method.Name }}", {{ $request.Name }}).inject(func() error { |
Contributor
Author
There was a problem hiding this comment.
This opens the gate for more targeted fault injection tests
stephanos
force-pushed
the
stephanos/onebox-purge-dlq
branch
4 times, most recently
from
7c286b5 to
43acb27
Compare
stephanos
force-pushed
the
stephanos/onebox-testhooks
branch
from
72aa7e0 to
2b42e10
Compare
stephanos
requested review from
long-nt-tran and
spkane31
and removed request for
spkane31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaced one
WithFxOptionsForServicewith fault injection.Why
We want to eliminate
WithFxOptionsForServiceas it is blocking us from migrating away from theonebox.goapproach (which duplicates the fx setup) since we don't want to expose an equivalent method intemporal/fx.go.