Skip to content

QVAC-23467 infra: drop @qvac/bare-sdk from sdk-pod-checks - #4109

Merged
opaninakuffo merged 2 commits into
mainfrom
chore/QVAC-23467-drop-bare-sdk-pod-checks
Aug 27, 2026
Merged

QVAC-23467 infra: drop @qvac/bare-sdk from sdk-pod-checks#4109
opaninakuffo merged 2 commits into
mainfrom
chore/QVAC-23467-drop-bare-sdk-pod-checks

Conversation

@opaninakuffo

@opaninakuffo opaninakuffo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • #4019 deletes packages/bare-sdk, but SDK Pod Checks read .github/sdk-pod-checks.json from base, not the PR. Main still lists bare-sdk, so that PR cds into a directory that no longer exists.

📝 How does it solve it?

  • Drop the bare-sdk entry from sdk-pod-checks.json while the package is still in the tree.

🧪 How was it tested?

  • No new tests. pr-checks-sdk-pod.yml checks out the PR base and filters this json by changed paths. A json-only change does not match packages/bare-sdk/, so this PR will not cd into that package.

@opaninakuffo
opaninakuffo requested review from a team as code owners August 27, 2026 10:30
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ✅ APPROVED
Approvals so far: Team Lead: 1, Member: 1

@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./.github/actions/release-merge-guard
  • ./docs/website
  • ./packages/ggml-coload-smoke
  • ./packages/fabric/test/integration
  • ./packages/inference-addon-cpp/mobile
  • ./packages/sdk/e2e
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/vla-ggml/sim/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/asr-ggml/benchmarks/server

@opaninakuffo
opaninakuffo merged commit 5876e71 into main Aug 27, 2026
27 checks passed
@opaninakuffo
opaninakuffo deleted the chore/QVAC-23467-drop-bare-sdk-pod-checks branch August 27, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants